Merge pull request #391 from NRCHKB/bugfix/onChange

Fixed onChange fired when value not changed #390

Author: Shaquu

CHANGELOG.md

@@ -11,6 +11,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.3.4]
+
+### Fixed
+
+- onChange fired when value not changed #390 - thanks for reporting @Delphius7
+
 ## [1.3.3]
 
 ### Fixed

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-homekit-bridged",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Node-RED nodes to simulate Apple HomeKit devices.",
   "main": "build/nodes/nrchkb.js",
   "scripts": {
@@ -57,21 +57,21 @@
     "@types/node-persist": "^3.1.1",
     "@types/node-red": "^1.1.1",
     "@types/semver": "^7.3.4",
-    "@typescript-eslint/eslint-plugin": "^4.20.0",
-    "@typescript-eslint/parser": "^4.20.0",
+    "@typescript-eslint/eslint-plugin": "^4.22.0",
+    "@typescript-eslint/parser": "^4.22.0",
     "babel-eslint": "^10.1.0",
-    "eslint": "^7.23.0",
-    "eslint-config-prettier": "^8.1.0",
+    "eslint": "^7.24.0",
+    "eslint-config-prettier": "^8.2.0",
     "eslint-plugin-prettier": "^3.3.1",
     "husky": "^6.0.0",
     "lint-staged": "^10.5.4",
     "mocha": "^8.3.2",
-    "node-red": "^1.2.9",
+    "node-red": "^1.3.2",
     "node-red-node-test-helper": "^0.2.7",
     "pinst": "^2.1.6",
     "prettier": "^2.2.1",
     "ts-node": "^9.1.1",
-    "typescript": "^4.2.3"
+    "typescript": "^4.2.4"
   },
   "husky": {
     "hooks": {

src/lib/utils/ServiceUtils.ts

@@ -168,16 +168,18 @@ module.exports = function (node: HAPServiceNodeType) {
             }`
         )
 
-        onValueChange.call(
-            this,
-            0,
-            {
-                oldValue,
-                newValue,
-                context,
-            },
-            originator
-        )
+        if (oldValue != newValue) {
+            onValueChange.call(
+                this,
+                0,
+                {
+                    oldValue,
+                    newValue,
+                    context,
+                },
+                originator
+            )
+        }
     }
 
     const onInput = function (msg: Record<string, any>) {