sync_experiment -s should be default True

[swu4bnl]

nslsii/nslsii/sync_experiment/sync_experiment.py

Line 338 in fa2e70a

parser.add_argument(

sync_experiment -s should be default True, for backwards compatibility for old workflows

[danielballan]

I could see the default cutting both ways: -s by default would be incompatible with any legacy unsecured Redis deployments (if there are any).

But I wonder why we need input from the user at all. Can we tell from the configured URL's scheme (redis: or rediss:) whether the connection is encrypted? And, if not, can we do what modern browser do: try encrypted first and fall back to unencrypted if encryption is not available?

[swu4bnl]

Dan Allan (@danielballan) Yes, I agree. It does not make much sense for users or beamline staff to decide the -s value manually. Most of us do not have enough context on this.

[danielballan]

I would suggest this behavior:

• If -s is not passed, follow whatever the URI says (redis:// versus rediss://).
• If -s is passed and the URI is insecure (redis://) raise an error.

Thus, -s becomes an option to mean, "Force secure." (curl has -proto https for this) But dropping the -s will still do the right thing in both old and new modes.