Merge branch 'main' into course-table

rileychh · rileychh · commit 342fd3ecdcc5 · 2026-02-28T20:35:31.000+08:00
diff --git a/.github/workflows/pr-preview.yaml b/.github/workflows/pr-preview.yaml
@@ -12,8 +12,13 @@ on:
         description: 'Specific commit SHA to build (overrides branch)'
         required: false
         type: string
-      skip_upload:
-        description: 'Build without uploading or bumping build number'
+      deploy_android:
+        description: 'Deploy Android to Firebase App Distribution'
+        required: false
+        type: boolean
+        default: true
+      deploy_ios:
+        description: 'Deploy iOS to TestFlight'
         required: false
         type: boolean
         default: false
@@ -36,7 +41,6 @@ jobs:
       # so this output may be an empty string. This is intentional; all downstream uses of
       # needs.prepare.outputs.comment_id are guarded by the same pull_request-only condition.
       comment_id: ${{ steps.create.outputs.comment-id }}
-      skip_upload: ${{ steps.flags.outputs.skip_upload }}
       target_ref: ${{ steps.set-ref.outputs.ref }}
     steps:
       - name: Checkout Actions
@@ -57,18 +61,7 @@ jobs:
         with:
           ref: ${{ steps.set-ref.outputs.ref }}
 
-      - name: Check for skip-upload flag
-        id: flags
-        run: |
-          COMMIT_MSG="$(git show -s --format=%B)"
-          if [[ "$COMMIT_MSG" == *"[skip upload]"* ]] || [[ "${{ inputs.skip_upload }}" == "true" ]]; then
-            echo "skip_upload=true" >> $GITHUB_OUTPUT
-          else
-            echo "skip_upload=false" >> $GITHUB_OUTPUT
-          fi
-
       - name: Manage Build Number
-        if: steps.flags.outputs.skip_upload != 'true'
         id: build-number
         uses: ./.github/actions/manage-build-number
         with:
@@ -83,17 +76,37 @@ jobs:
           build_number: ${{ steps.build-number.outputs.build_number || vars.build_number }}
 
       - name: Find existing comment
-        if: github.event_name == 'pull_request' && steps.flags.outputs.skip_upload != 'true'
+        if: github.event_name == 'pull_request'
         uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4
         id: find-comment
         with:
           issue-number: ${{ github.event.pull_request.number }}
           comment-author: github-actions[bot]
           body-includes: <!-- pr-preview-comment -->
 
+      - name: Read existing deploy checkboxes
+        id: checkboxes
+        if: github.event_name == 'pull_request'
+        env:
+          COMMENT_BODY: ${{ steps.find-comment.outputs.comment-body }}
+        run: |
+          ANDROID="x"
+          IOS=" "
+          BODY="$COMMENT_BODY"
+          if [ -n "$BODY" ]; then
+            if echo "$BODY" | grep -q '<!-- deploy-android -->'; then
+              [[ "$BODY" =~ \[x\]\ \<\!--\ deploy-android ]] && ANDROID="x" || ANDROID=" "
+            fi
+            if echo "$BODY" | grep -q '<!-- deploy-ios -->'; then
+              [[ "$BODY" =~ \[x\]\ \<\!--\ deploy-ios ]] && IOS="x" || IOS=" "
+            fi
+          fi
+          echo "android=$ANDROID" >> $GITHUB_OUTPUT
+          echo "ios=$IOS" >> $GITHUB_OUTPUT
+
       - name: Create or update initial comment
         id: create
-        if: github.event_name == 'pull_request' && steps.flags.outputs.skip_upload != 'true'
+        if: github.event_name == 'pull_request'
         uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
         with:
           comment-id: ${{ steps.find-comment.outputs.comment-id }}
@@ -104,6 +117,10 @@ jobs:
             **Build Number:** ${{ steps.build-number.outputs.build_number }}
             **Commit:** ${{ steps.summary.outputs.sha }}
             **Message:** ${{ steps.summary.outputs.message }}
+
+            ### Deploy
+            - [${{ steps.checkboxes.outputs.android }}] <!-- deploy-android --> Android (Firebase App Distribution)
+            - [${{ steps.checkboxes.outputs.ios }}] <!-- deploy-ios --> iOS (TestFlight)
           edit-mode: replace
 
   android:
@@ -131,22 +148,51 @@ jobs:
         with:
           platform: android
 
+      - name: Find preview comment
+        if: github.event_name == 'pull_request'
+        uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4
+        id: find-comment
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          comment-author: github-actions[bot]
+          body-includes: <!-- pr-preview-comment -->
+
+      - name: Check deploy checkbox
+        id: check-deploy
+        env:
+          COMMENT_BODY: ${{ steps.find-comment.outputs.comment-body }}
+        run: |
+          BODY="$COMMENT_BODY"
+          if [ -z "$BODY" ]; then
+            if [ "${{ github.event_name }}" = "workflow_dispatch" ] && [ "${{ inputs.deploy_android }}" != "false" ]; then
+              echo "skip_upload=false" >> $GITHUB_OUTPUT
+            else
+              echo "skip_upload=true" >> $GITHUB_OUTPUT
+            fi
+            exit 0
+          fi
+          if echo "$BODY" | grep -q '\[x\] <!-- deploy-android -->'; then
+            echo "skip_upload=false" >> $GITHUB_OUTPUT
+          else
+            echo "skip_upload=true" >> $GITHUB_OUTPUT
+          fi
+
       - name: Build and upload to Firebase App Distribution
         id: upload
         env:
           FIREBASEAPPDISTRO_APP: ${{ secrets.FIREBASEAPPDISTRO_APP }}
-        run: bundle exec fastlane android preview skip_upload:${{ needs.prepare.outputs.skip_upload }}
+        run: bundle exec fastlane android preview skip_upload:${{ steps.check-deploy.outputs.skip_upload }}
 
       - name: Write Android Job Summary
-        if: needs.prepare.outputs.skip_upload != 'true'
+        if: steps.check-deploy.outputs.skip_upload != 'true'
         uses: ./.github/actions/android-summary
         with:
           build_number: ${{ needs.prepare.outputs.build_number }}
           type: 'firebase'
           testing_uri: ${{ steps.upload.outputs.testing_uri }}
 
       - name: Update comment with Android build
-        if: github.event_name == 'pull_request' && needs.prepare.outputs.skip_upload != 'true'
+        if: github.event_name == 'pull_request' && steps.check-deploy.outputs.skip_upload != 'true'
         uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
         with:
           comment-id: ${{ needs.prepare.outputs.comment_id }}
@@ -190,17 +236,46 @@ jobs:
           cd ios && bundle exec pod install
           git diff --exit-code Podfile.lock
 
+      - name: Find preview comment
+        if: github.event_name == 'pull_request'
+        uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4
+        id: find-comment
+        with:
+          issue-number: ${{ github.event.pull_request.number }}
+          comment-author: github-actions[bot]
+          body-includes: <!-- pr-preview-comment -->
+
+      - name: Check deploy checkbox
+        id: check-deploy
+        env:
+          COMMENT_BODY: ${{ steps.find-comment.outputs.comment-body }}
+        run: |
+          BODY="$COMMENT_BODY"
+          if [ -z "$BODY" ]; then
+            if [ "${{ github.event_name }}" = "workflow_dispatch" ] && [ "${{ inputs.deploy_ios }}" != "false" ]; then
+              echo "skip_upload=false" >> $GITHUB_OUTPUT
+            else
+              echo "skip_upload=true" >> $GITHUB_OUTPUT
+            fi
+            exit 0
+          fi
+          if echo "$BODY" | grep -q '\[x\] <!-- deploy-ios -->'; then
+            echo "skip_upload=false" >> $GITHUB_OUTPUT
+          else
+            echo "skip_upload=true" >> $GITHUB_OUTPUT
+          fi
+
       - name: Build and Upload to TestFlight
-        run: bundle exec fastlane ios beta skip_upload:${{ needs.prepare.outputs.skip_upload }}
+        run: bundle exec fastlane ios beta skip_upload:${{ steps.check-deploy.outputs.skip_upload }}
 
       - name: Write iOS Job Summary
-        if: needs.prepare.outputs.skip_upload != 'true'
+        if: steps.check-deploy.outputs.skip_upload != 'true'
         uses: ./.github/actions/ios-summary
         with:
           build_number: ${{ needs.prepare.outputs.build_number }}
 
       - name: Update comment with iOS build
-        if: github.event_name == 'pull_request' && needs.prepare.outputs.skip_upload != 'true'
+        if: github.event_name == 'pull_request' && steps.check-deploy.outputs.skip_upload != 'true'
         uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
         with:
           comment-id: ${{ needs.prepare.outputs.comment_id }}
diff --git a/.github/workflows/release-preview.yaml b/.github/workflows/release-preview.yaml
@@ -123,7 +123,7 @@ jobs:
           platform: ios
 
       - name: Build and Upload to TestFlight (App Store Connect)
-        run: bundle exec fastlane ios beta release_mode:true
+        run: bundle exec fastlane ios beta
 
       - name: Write iOS Job Summary
         uses: ./.github/actions/ios-summary
diff --git a/doc/Dockerfile b/doc/Dockerfile
@@ -23,17 +23,11 @@ RUN --mount=type=cache,target=/mise/cache \
     mise trust && \
     mise install flutter
 
-# Resolve app dependencies
-COPY pubspec.* ./
-RUN --mount=type=cache,target=/root/.pub-cache \
-    flutter --disable-analytics && \
-    flutter pub get --enforce-lockfile
-
-# Copy app source code
+# Resolve app dependencies and generate documentation
 COPY . .
-
-# Generate documentation
 RUN --mount=type=cache,target=/root/.pub-cache \
+    flutter --disable-analytics && \
+    flutter pub get --enforce-lockfile && \
     dart doc
 
 FROM caddy:2-alpine@sha256:4c6e91c6ed0e2fa03efd5b44747b625fec79bc9cd06ac5235a779726618e530d
diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -19,6 +19,41 @@ def changelog(pr_number, pr_title, commit_sha, commit_message)
 end
 
 platform :ios do
+  desc "Build, install on connected device, and upload dSYMs"
+  lane :device do
+    sync_code_signing(type: "adhoc")
+
+    update_code_signing_settings(
+      path: "ios/Runner.xcodeproj",
+      sdk: "iphoneos*",
+      code_sign_identity: "iPhone Distribution",
+      profile_name: "match AdHoc #{ENV["FASTLANE_APP_IDENTIFIER"]}",
+    )
+
+    archive_path = flutter_build(
+      build: "ipa",
+      build_args: ["--no-codesign", "--dart-define=USE_FIREBASE=true"],
+    )
+
+    build_app(
+      skip_build_archive: true,
+      archive_path: archive_path,
+      export_team_id: ENV["FASTLANE_TEAM_ID"],
+      export_method: "ad-hoc",
+      suppress_xcode_output: true,
+    )
+
+    install_on_device(ipa: lane_context[SharedValues::IPA_OUTPUT_PATH])
+
+    Dir.chdir("..") { sh("dart", "run", "tool/credentials.dart", "fetch") }
+
+    upload_symbols_to_crashlytics(
+      dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH],
+      gsp_path: "ios/Runner/GoogleService-Info.plist",
+      binary_path: "ios/Pods/FirebaseCrashlytics/upload-symbols",
+    )
+  end
+
   desc "Build and upload to TestFlight"
   lane :beta do |options|
     build_number = options[:build_number] || ENV["BUILD_NUMBER"] || 1
@@ -27,7 +62,6 @@ platform :ios do
     commit_sha = options[:commit_sha] || ENV["COMMIT_SHA"] || "manual build"
     commit_message = options[:commit_message] || ENV["COMMIT_MESSAGE"] || "This is a manual build without PR information"
     skip_upload = options[:skip_upload].to_s == "true"
-    release_mode = options[:release_mode].to_s == "true"
 
     setup_ci if is_ci
 
@@ -47,7 +81,7 @@ platform :ios do
     archive_path = flutter_build(
       build: "ipa",
       build_number: build_number,
-      build_args: ["--no-codesign", "--dart-define=USE_FIREBASE=#{release_mode ? 'true' : 'false'}"],
+      build_args: ["--no-codesign", "--dart-define=USE_FIREBASE=true"],
     )
 
     build_app(
@@ -59,6 +93,14 @@ platform :ios do
 
     next if skip_upload
 
+    Dir.chdir("..") { sh("dart", "run", "tool/credentials.dart", "fetch") }
+
+    upload_symbols_to_crashlytics(
+      dsym_path: lane_context[SharedValues::DSYM_OUTPUT_PATH],
+      gsp_path: "ios/Runner/GoogleService-Info.plist",
+      binary_path: "ios/Pods/FirebaseCrashlytics/upload-symbols",
+    )
+
     app_store_connect_api_key(
       is_key_content_base64: true,
     )
@@ -87,6 +129,7 @@ platform :android do
     output_file = flutter_build(
       build: "appbundle",
       build_number: build_number,
+      build_args: ["--dart-define=USE_FIREBASE=true"],
     )
 
     next if skip_upload
diff --git a/fastlane/README.md b/fastlane/README.md
@@ -15,6 +15,14 @@ For _fastlane_ installation instructions, see [Installing _fastlane_](https://do
 
 ## iOS
 
+### ios device
+
+```sh
+[bundle exec] fastlane ios device
+```
+
+Build, install on connected device, and upload dSYMs
+
 ### ios beta
 
 ```sh
diff --git a/lib/screens/main/profile/profile_screen.dart b/lib/screens/main/profile/profile_screen.dart
@@ -146,6 +146,12 @@ class ProfileScreen extends ConsumerWidget {
       ),
 
       SectionHeader(title: 'TAT'),
+      // TODO: remove before release
+      OptionEntryTile(
+        icon: Icons.rice_bowl_outlined,
+        title: '點一碗炒飯',
+        onTap: () => throw Exception('炒飯'),
+      ),
       OptionEntryTile(
         icon: Icons.favorite_border_outlined,
         title: t.profile.options.supportUs,
