Skip to content

Commit ffbffca

Browse files
committed
add timers to break down free
1 parent 47ed220 commit ffbffca

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

src/drivers/ncmpio/ncmpio_close.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ ncmpio_close(void *ncdp)
217217
MPI_File_seek(fh, 0, MPI_SEEK_END);
218218
MPI_File_get_position(fh, &file_size);
219219
/* truncate file size to header size, if larger than header */
220-
if (file_size > ncp->xsz} {
220+
if (file_size > ncp->xsz) {
221221
mpireturn = MPI_File_set_size(fh, ncp->xsz);
222222
if (mpireturn != MPI_SUCCESS) {
223223
err = ncmpii_error_mpi2nc(mpireturn,"MPI_File_set_size");

src/drivers/ncmpio/ncmpio_dim.c

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,19 @@ ncmpio_free_NC_dimarray(NC_dimarray *ncap)
120120
int i;
121121

122122
assert(ncap != NULL);
123-
// double start_time;
124-
// double free_dim_array_time;
125-
// double free_dim_extra_time;
126-
// double free_dim_hash_time;
123+
double start_time;
124+
double free_dim_array_time;
125+
double free_dim_hash_time;
126+
start_time = MPI_Wtime();
127+
int hash_size = ncap->hash_size;
128+
int ndefined = ncap->ndefined;
129+
int rank;
130+
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
127131
if (ncap->value != NULL) {
128132
/* when error is detected reading NC_DIMENSION tag, ncap->ndefined can
129133
* be > 0 and ncap->value is still NULL
130134
*/
131-
// start_time = MPI_Wtime();
135+
132136
for (i=0; i<ncap->ndefined; i++) {
133137
/* when error is detected reading dimension i, ncap->value[i] can
134138
* still be NULL
@@ -138,11 +142,12 @@ ncmpio_free_NC_dimarray(NC_dimarray *ncap)
138142
NCI_Free(ncap->value[i]);
139143
}
140144
NCI_Free(ncap->value);
141-
// free_dim_array_time = MPI_Wtime() - start_time;
145+
142146

143147
}
148+
free_dim_array_time = MPI_Wtime() - start_time;
144149
ncap->ndefined = 0;
145-
// start_time = MPI_Wtime();
150+
start_time = MPI_Wtime();
146151
#ifndef SEARCH_NAME_LINEARLY
147152
/* free space allocated for dim name lookup table */
148153
if (ncap->nameT != NULL) {
@@ -152,8 +157,9 @@ ncmpio_free_NC_dimarray(NC_dimarray *ncap)
152157
ncap->hash_size = 0;
153158
}
154159
#endif
155-
// free_dim_hash_time = MPI_Wtime() - start_time;
156-
// printf("free_dim_array_time: %f, free_dim_hash_time: %f\n", free_dim_array_time, free_dim_hash_time);
160+
free_dim_hash_time = MPI_Wtime() - start_time;
161+
if (rank == 0)
162+
printf("free_dim_array_time (%d dims): %f, free_dim_hash_time (%d hash size): %f\n", ndefined, free_dim_array_time, hash_size, free_dim_hash_time);
157163
}
158164

159165
/*----< ncmpio_dup_NC_dimarray() >-------------------------------------------*/

0 commit comments

Comments
 (0)