Import Options API Get is null for Fail Option when set to Keep Existing

[drgrieg]

In a collection, if i set the Import option for "Fail:" to "Keep Existing" the API objects in the JSON Tree shows "null" is this correct? shouldn't it be something like "keep"? I am using the latest version 1.6.12

[cd-rite]

Hi @drgrieg That's actually by design, it's a "null" string, not a raw null, representing that no changes should be made for the "fail" case (ie. "keep existing").
You can see this in our schema:

    CollectionImportAutoStatus:
      type: object
      additionalProperties: false
      description: |
        Determines how to set the status property of imported reviews for each evaluation result.
        Each property must be one of:
         - 'null': Don't set a status (Keep existing Review Status)
         - 'saved': Always set status to 'saved'
         - 'submitted': Set status to 'submitted' if the review is submittable per Collection settings
         - 'accepted': Set status to 'accepted' if the review is submittable, and User has permission to accept,  otherwise 'submitted'

[drgrieg]

ok great! thanks for pointing that out and the reference to the schema.

[drgrieg]

@cd-rite Actually, i think this still may be an issue. I found that EvaluateSTIG is looking up the autostatus objects for fail to send that status to stigmanager and it is getting that null string as the configured object:"
"Open" { $result = "notapplicable" $status = $ImportRules.settings.importOptions.autostatus.fail }
Then, when it submits that fail to stigmanager, it tries sending that null status according to the import settings and gets back an error from stigmanager that says:
error : request/body/6/status must be equal to one of the allowed values: **saved, submitted, accepted, rejected**, request/body/6/status must be object, request/body/6/status must match exactly one schema in oneOf

The API doesn't appear to accept the null property so that it leaves fails alone. I am trying to set it like this so that way i can add comments to my fails, and subsequent scans don't overwrite my comments. I know i'm supposed to be able to drag history objects into the review, but that only populates the result and detail elements and does not populate comments box requiring me to have to open up the history object, expand the comment, then copy paste into the new review comment field manually. I only want subsequent fails to go back to saved status if the details or comments change but it never gets there because of the null status evaluatestig is trying to send.

I also found that for Not Reviewed status, evaluatestig doesnt do a lookup for what that is set to in stigmanager and instead sends a static "saved" status every time so that means for all the not reviewed items that i have commented on and changed results to not a finding in stigmanager, subsequent scans erase that input as well. by them sending the "saved" status it overrides the stigmanager import option of "Include unreviewed rules: Never" I tried to temporarily modify evaluatestig to do the lookup for this "never" object from the API and send that but again, the API wants only saved, submitted, accepted, rejected

[onmylayne]

I want to add to this thread that I am also experiencing the same issue @drgrieg pointed out. For the last 2 days I been banging my head against my desk troubleshooting why the Import option for "Fail:" to "Keep Existing" was not updating Open rules to Not a Finding when they had been fixed and validated. Once I changed the Import option for "Fail:" to "Saved" the rules were updated to Not a Finding.