Skip to content

[BUG] convert to raw missing last day in train #471

@noahnisbet

Description

@noahnisbet

Describe the bug
In convert_to_raw.py in the DLRM sample it seems like the logic is incorrect on the number of days. When creating the list under the function "_get_days_for_stage," list(range(NUM_DAYS - 1)) is returned for the train stage. However, wouldn't this exclude day 23? The range function is already exclusive on the highest value. list(range(NUM_DAYS)) seems like it should be correct.

To Reproduce
Run HugeCTR/samples/dlrm/preprocessing/covert_to_raw.py as described in the documentation.

Expected behavior
Processing all 24 days (0-23)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions