Skip to content

Commit 28a723f

Browse files
authored
chore: Update dependencies to address CVEs and also update Dockerfile (#15756)
* ci: Remove Dockerfile.stable Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Rename Dockerfile.ci to Dockerfile Signed-off-by: Charlie Truong <chtruong@nvidia.com> * ci: Rename Dockerfile.ci to Dockerfile Signed-off-by: Charlie Truong <chtruong@nvidia.com> * chore: Bump dependencies to address CVEs Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Build docker container for release Signed-off-by: Charlie Truong <chtruong@nvidia.com> * chore: Update uv.lock Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
1 parent c703649 commit 28a723f

9 files changed

Lines changed: 318 additions & 269 deletions

File tree

.github/actions/test-template/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ runs:
121121
--name nemo_container_${{ github.run_id }}_${{ inputs.runner }} ${ARG[@]} \
122122
--shm-size=64g \
123123
--env TRANSFORMERS_OFFLINE=0 \
124+
--env NEMO_HOME="/home/TestData/nemo_home" \
124125
--env HYDRA_FULL_ERROR=1 \
125126
--env HF_HOME=/home/TestData/HF_HOME \
126127
--env RUN_ID=${{ github.run_id }} \

.github/workflows/cicd-main-speech.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: ./.github/workflows/_build_container.yml
3939
with:
4040
image-name: ${{ inputs.image-name }}
41-
dockerfile: docker/Dockerfile.ci
41+
dockerfile: docker/Dockerfile
4242
runner: ${{ inputs.runner }}
4343

4444
unit-tests:

.github/workflows/cicd-main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ jobs:
176176
&& !cancelled()
177177
with:
178178
image-name: nemo_container
179-
dockerfile: docker/Dockerfile.ci
179+
dockerfile: docker/Dockerfile
180180
runner: ${{ needs.pre-flight.outputs.runner_prefix }}
181181
registry: ${{ needs.pre-flight.outputs.registry }}
182182

.github/workflows/release-freeze.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ jobs:
5858
cd ${{ github.run_id }}
5959
find tutorials -type f -name "*.ipynb" -exec sed -i "s/BRANCH = 'main'/BRANCH = '${{ needs.code-freeze.outputs.release-branch }}'/g" {} +
6060
61-
- name: Pin MCore in Dockerfile
62-
run: |
63-
cd ${{ github.run_id }}
64-
sed -i 's/^ARG MCORE_TAG=.*$/ARG MCORE_TAG=${{ inputs.mcore_version }}/' docker/Dockerfile.ci
65-
6661
- name: Show status
6762
run: |
6863
cd ${{ github.run_id }}

.github/workflows/update-buildcache.yml

Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ COPY nemo/__init__.py nemo/package_info.py /workspace/nemo/
5353
RUN <<"EOF" bash -ex
5454
uv sync --link-mode copy --locked --extra all --extra cu13 --group test
5555
EOF
56+
COPY nemo /workspace/nemo
5657

5758
FROM base-image AS automodel-deps
5859
ARG GPU_TARGET=h100plus
@@ -188,13 +189,13 @@ EOF
188189
FROM base-image
189190
COPY --from=automodel-deps /opt/venv /opt/venv
190191

191-
ENV NEMO_HOME="/home/TestData/nemo_home"
192+
ENV NVIDIA_BUILD_ID=${NVIDIA_BUILD_ID:-<unknown>}
193+
LABEL com.nvidia.build.id="${NVIDIA_BUILD_ID}"
194+
ARG NVIDIA_BUILD_REF
195+
LABEL com.nvidia.build.ref="${NVIDIA_BUILD_REF}"
196+
ARG RC_DATE=00.00
197+
ARG TARGETARCH
192198

193-
ARG IMAGE_LABEL
194-
LABEL "nemo.library"=${IMAGE_LABEL}
195-
196-
ARG PR_NUMBER
197-
LABEL "nemo.pr_number"=${PR_NUMBER}
198-
199-
ARG NVIDIA_BUILD_ID
200-
LABEL "NVIDIA_BUILD_ID"=${NVIDIA_BUILD_ID}
199+
# NOTICES.txt file points to where the OSS source code is archived
200+
RUN echo "This distribution includes open source which is archived at the following URL: https://opensource.nvidia.com/oss/teams/nvidia/nemo/${RC_DATE}:linux-${TARGETARCH}/index.html" > NOTICES.txt && \
201+
echo "For further inquiries or assistance, contact us at oss-requests@nvidia.com" >> NOTICES.txt

docker/Dockerfile.stable

Lines changed: 0 additions & 76 deletions
This file was deleted.

pyproject.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,11 @@ conflicts = [
444444
]
445445
override-dependencies = [
446446
"torch==2.12.0+cu132 ; sys_platform == 'linux'",
447+
"mlflow>=3.9.0rc0",
448+
"cryptography>=46.0.5",
449+
"wandb>=0.27.1",
450+
"urllib3>=2.6.0",
451+
"opencv-python-headless; sys_platform == 'never'"
447452
]
448453
no-binary-package = [
449454
"causal-conv1d",
@@ -489,7 +494,7 @@ explicit = true
489494

490495
[dependency-groups]
491496
test = [
492-
"black~=24.3",
497+
"black>=26.3.1",
493498
"click>=8.1",
494499
"coverage",
495500
"isort>5.1.0,<6.0.0",

0 commit comments

Comments
 (0)