You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: removed all gretel mentions when appropriate (#219)
# Summary
All "gretel" mentions in `src/` have been removed or replaced with
product-appropriate alternatives ("nss" for Nemo Safe Synthesizer).
External dataset URLs referencing `gretelai/gretel-blueprints` are kept
as-is since they point to a public data source.
## Code Identifiers Renamed
| File | Old | New |
|---|---|---|
| `records/fragment.py` | `gretel_id` (attribute + params) | `record_id`
|
| `records/fragment.py` | `gretel_fragment_ts` | `fragment_ts` |
| `records/fragment.py` | `gretel_fragment_epoch` | `fragment_epoch` |
| `records/fragment.py` | `gretel_fragment_datetime` |
`fragment_datetime` |
| `records/json_record.py` | `remove_gretel_array_markers()` |
`remove_array_markers()` |
| `records/base.py` | `"_gretelarray_"` | `"_nssarray_"` |
| `actions/utils.py` | `"__gretel__idx"` | `"__nss__idx"` |
| `actions/utils.py` | `"__gretel_reject_reason"` |
`"__nss_reject_reason"` |
## Constants Renamed (`pii_replacer/ner/const.py`)
| Old Key / Value | New Key / Value |
|---|---|
| `GRETEL_ID` / `_gretel_id` | `NSS_ID` / `_nss_id` |
| `GRETEL_TS` / `_gretel_ts` | `NSS_TS` / `_nss_ts` |
| `GRETEL_SUB` / `_gretel_subscriber` | `NSS_SUB` / `_nss_subscriber` |
| `ARRAY_POS` / `_gretelarray_` | `ARRAY_POS` / `_nssarray_` |
## Environment Variables Renamed (`pii_replacer/ner/models.py`)
| Old | New |
|---|---|
| `GRETEL_OPT_BUCKET` | `NSS_OPT_BUCKET` |
| `gretel-opt-dev-use2` (default bucket) | `nss-opt-dev-use2` |
| `GRETEL_OPT_CACHE_DIR` | `NSS_OPT_CACHE_DIR` |
## Comments / Documentation Cleaned Up
| File | Change |
|---|---|
| `src/.../record_utils.py` | "gretel client" → "nss client" |
| `src/.../pii_replacer/ner/models.py` | Removed "gretel" from
docstrings about visibility and cache management |
| `src/.../pii_replacer/ner/regexes/age.py` | Replaced internal GitHub
issue URL with descriptive comment |
| `src/.../pii_replacer/ner/regexes/sex_gender.py` | Replaced internal
GitHub issue URL with descriptive comment |
| `src/.../artifacts/analyzers/field_features.py` | Removed internal
GitHub repo URL |
| `src/.../records/fragment.py` | Error message: "different gretel
records" → "different records" |
| `tests/evaluation/conftest.py` | "gretel core arfifact classifier" →
"core artifact classifier" |
## Kept As-Is
- External dataset URLs referencing `gretelai/gretel-blueprints`
(third-party public data source)
- Historical tag references in test comments (`gretel-2025-02-25 tag`)
## Migration Notes
- **Environment variables**: Anyone previously setting
`GRETEL_OPT_BUCKET` or `GRETEL_OPT_CACHE_DIR` must update to
`NSS_OPT_BUCKET` / `NSS_OPT_CACHE_DIR`.
## Pre-Review Checklist
<!-- These checks should be completed before a PR is reviewed, -->
<!-- but you can submit a draft early to indicate that the issue is
being worked on. -->
Ensure that the following pass:
- [x] `make format && make check` or via prek validation.
- [x] `make test` passes locally
- [x] `make test-e2e` passes locally
- [ ] `make test-ci-container` passes locally (recommended)
## Pre-Merge Checklist
<!-- These checks need to be completed before a PR is merged, -->
<!-- but as PRs often change significantly during review, -->
<!-- it's OK for them to be incomplete when review is first requested.
-->
- [ ] New or updated tests for any fix or new behavior
- [ ] Updated documentation for new features and behaviors, including
docstrings for API docs.
## Other Notes
<!-- Please add the issue number that should be closed when this PR is
merged. -->
- Closes#218
---------
Signed-off-by: Sean Yang <seayang@nvidia.com>
Signed-off-by: seayang-nv <seayang@nvidia.com>
0 commit comments