Skip to content

Commit 883db1d

Browse files
committed
gitignore strikes
1 parent 682c53a commit 883db1d

12 files changed

Lines changed: 656 additions & 170 deletions

File tree

.github/CODEOWNERS

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
33

44
# Default reviewers for all files
5-
* @NVIDIA-NeMo/safe-synthesizer-reviewers
5+
* @NVIDIA-NeMo/safe-synthesizer-maintainers
6+
7+
src/ @NVIDIA-NeMo/safe-synthesizer-reviewers
8+
tests/ @NVIDIA-NeMo/safe-synthesizer-reviewers
69

710
# Critical files require maintainers
811
pyproject.toml @NVIDIA-NeMo/safe-synthesizer-maintainers

.github/workflows/README.md

Lines changed: 15 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This directory contains GitHub Actions workflows for CI/CD automation.
1616
## Workflow Diagram
1717

1818
```mermaid
19-
flowchart TD
19+
flowchart LR
2020
subgraph triggers [Triggers]
2121
push[Push to main]
2222
pr[Pull Request]
@@ -25,9 +25,11 @@ flowchart TD
2525
end
2626
2727
subgraph ci [CI Workflow]
28-
lint[Lint Job]
29-
format[Format Check Job]
30-
test[Test Job - Matrix]
28+
lint[Lint]
29+
format[Format Check]
30+
typecheck[Typecheck]
31+
test[Unit Tests]
32+
test --> coverage[Coverage Report]
3133
end
3234
3335
subgraph compliance [Compliance Workflows]
@@ -38,42 +40,25 @@ flowchart TD
3840
end
3941
4042
subgraph release [Release Workflow]
41-
releaseLib[_release_library.yml]
4243
buildWheel[Build Wheel]
4344
bumpVersion[Bump Version]
4445
publishPyPI[Publish to PyPI]
4546
ghRelease[GitHub Release]
4647
slackNotify[Slack Notification]
4748
end
4849
49-
subgraph templates [FW-CI-templates]
50-
tpl_semantic[_semantic_pull_request.yml]
51-
tpl_secrets[_secrets-detector.yml]
52-
tpl_copyright[_copyright_check.yml]
53-
tpl_release[_release_library.yml]
54-
end
55-
5650
push --> ci
5751
pr --> ci
58-
pr --> conventional
59-
pr --> secrets
60-
pr --> copyright
61-
pr --> dco
52+
pr --> compliance
6253
comment --> dco
63-
manual --> releaseLib
64-
65-
releaseLib --> buildWheel
66-
releaseLib --> bumpVersion
67-
buildWheel --> publishPyPI
68-
publishPyPI --> ghRelease
69-
ghRelease --> slackNotify
54+
manual --> release
7055
71-
conventional -.->|reuses| tpl_semantic
72-
secrets -.->|reuses| tpl_secrets
73-
copyright -.->|reuses| tpl_copyright
74-
releaseLib -.->|reuses| tpl_release
56+
buildWheel --> publishPyPI --> ghRelease --> slackNotify
7557
76-
test --> coverage[Coverage Report]
58+
conventional -.->|reuses| FW-CI-templates
59+
secrets -.->|reuses| FW-CI-templates
60+
copyright -.->|reuses| FW-CI-templates
61+
release -.->|reuses| FW-CI-templates
7762
```
7863

7964
## CI Workflow
@@ -84,9 +69,9 @@ The main CI workflow runs on every push to `main` and on pull requests:
8469
- **Format Check**: Verifies code formatting with `ruff format --check`
8570
- **Test**: Runs pytest with coverage across Python 3.11, 3.12, and 3.13
8671

87-
### Coverage Requirements
72+
### Coverage
8873

89-
Tests must maintain at least 80% code coverage. Coverage reports are uploaded as artifacts.
74+
Coverage reports are uploaded as artifacts.
9075

9176
## Compliance Workflows
9277

.github/workflows/ci-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
name: ci-checks
15+
name: CI - checks
1616

1717
on:
1818
push:

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ AGENTS.local.md
44
CLAUDE.local.md
55
.claude/settings.local.json
66
ai/tmp/
7-
venv*
8-
env*
7+
venv*/
8+
env*/
99
.env*
1010
temp
1111
__pycache__/*

0 commit comments

Comments
 (0)