Skip to content

Commit bd044b0

Browse files
authored
chore(ci): remove dev-wheel and copyright, always run format, tweak (#336)
* Removes two workflows we don't really use * Makes sure format always runs, tweak other workflows to run more Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
1 parent ec0884b commit bd044b0

6 files changed

Lines changed: 6 additions & 160 deletions

File tree

.agents/skills/github-cli/SKILL.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ The project has 7 GitHub Actions workflows:
106106
| CI Checks | `ci-checks.yml` | push to main, PRs, manual | format, lint, typecheck, unit-test |
107107
| GPU jobs | `gpu-tests.yml` | push to main, push to `pull-request/<N>`, manual | e2e on A100 (copy-pr-bot; see below) |
108108
| Conventional Commit | `conventional-commit.yml` | PR title changes | Validates PR title format |
109-
| Copyright Check | `copyright-check.yml` | push to main, release branches | NVIDIA copyright headers |
110109
| DCO Assistant | `dco-assistant.yml` | PR events, comments | Developer Certificate of Origin |
111110
| Release | `release.yml` | manual dispatch only | Build and publish to PyPI |
112111
| Secrets Detector | `secrets-detector.yml` | PRs to main | Scans for leaked secrets |

.github/workflows/README.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ All workflows that use `.github/actions/setup-python-env` now default to the ver
1414
| [ci-checks.yml](ci-checks.yml) | Push to `main`, PRs, manual | Format, typecheck, unit tests, and CPU smoke tests |
1515
| [gpu-tests.yml](gpu-tests.yml) | Push to `main`/`pull-request/*`, manual | GPU smoke tests (required) and E2E tests (A100) |
1616
| [conventional-commit.yml](conventional-commit.yml) | PRs | Validates PR titles follow conventional commit format |
17-
| [copyright-check.yml](copyright-check.yml) | Push to `main`/`pull-request/*` | Validates NVIDIA copyright headers on Python files |
1817
| [docs.yml](docs.yml) | Push to `main` (docs paths) | Builds and deploys documentation to GitHub Pages |
1918
| [internal-release.yml](internal-release.yml) | Tag push (`v[0-9]*`), manual dispatch | Builds and publishes wheel to Artifactory or PyPI |
2019
| [release.yml](release.yml) | Manual dispatch | Builds and publishes package to PyPI (production) |
@@ -93,7 +92,7 @@ flowchart LR
9392
end
9493
9594
push --> ci & gpu
96-
cpb --> gpu & copyright
95+
cpb --> gpu
9796
pr --> ci & conventional & secrets
9897
manual --> release
9998
tag[Tag push v[0-9]*] --> internalRelease
@@ -103,7 +102,6 @@ flowchart LR
103102
104103
conventional -.->|reuses| FW-CI-templates
105104
secrets -.->|reuses| FW-CI-templates
106-
copyright -.->|reuses| FW-CI-templates
107105
release -.->|reuses| FW-CI-templates
108106
```
109107

@@ -200,10 +198,6 @@ Or comment on the PR: `I have read the DCO Document and I hereby sign the DCO`
200198

201199
Scans PRs for accidentally committed secrets. False positives can be added to `.github/workflows/config/.secrets.baseline`.
202200

203-
### Copyright Check
204-
205-
Validates that Python files have proper NVIDIA copyright headers.
206-
207201
## Internal Release Workflow
208202

209203
The `internal-release.yml` workflow builds a wheel and publishes it to NVIDIA Artifactory or PyPI.

.github/workflows/ci-checks.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ jobs:
5757

5858
format:
5959
name: Format
60-
needs: changes
61-
if: ${{ needs.changes.outputs.src == 'true' || needs.changes.outputs.deps == 'true' || github.event_name == 'workflow_dispatch' }}
6260
runs-on: ubuntu-latest
6361
steps:
6462
- name: checkout
@@ -85,7 +83,7 @@ jobs:
8583
typecheck:
8684
name: Typecheck
8785
needs: changes
88-
if: ${{ needs.changes.outputs.src == 'true' || needs.changes.outputs.deps == 'true' || github.event_name == 'workflow_dispatch' }}
86+
if: ${{ needs.changes.outputs.src == 'true' || needs.changes.outputs.test == 'true' || needs.changes.outputs.deps == 'true' || github.event_name == 'workflow_dispatch' }}
8987
runs-on: ubuntu-latest
9088
steps:
9189
- name: checkout
@@ -146,7 +144,7 @@ jobs:
146144
smoke-test:
147145
name: Smoke Tests
148146
needs: changes
149-
if: ${{ needs.changes.outputs.src == 'true' || needs.changes.outputs.test == 'true' || github.event_name == 'workflow_dispatch' }}
147+
if: ${{ needs.changes.outputs.src == 'true' || needs.changes.outputs.test == 'true' || needs.changes.outputs.deps == 'true' || github.event_name == 'workflow_dispatch' }}
150148
runs-on: ubuntu-latest
151149
steps:
152150
- name: checkout

.github/workflows/copyright-check.yml

Lines changed: 0 additions & 56 deletions
This file was deleted.

.github/workflows/dev-wheel.yml

Lines changed: 0 additions & 92 deletions
This file was deleted.

tests/stub_datasets/licenses.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
<!-- SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
2+
<!-- SPDX-License-Identifier: Apache-2.0 -->
3+
14
### CLINC OOS (`clinc_oos.csv`)
25

36
[Licensed](https://github.com/clinc/oos-eval/blob/master/LICENSE) under CC-BY-3.0 (Creative Commons Attribution 3.0 Unported).

0 commit comments

Comments
 (0)