Skip to content

Commit 5b6299c

Browse files
authored
Improvements for K8s actions (#1477)
1 parent be672a1 commit 5b6299c

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

.github/container/test-axlearn.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,3 +243,10 @@ echo "Total number of failed tests ${failed}"
243243
echo "Total number of skipped tests ${skipped}"
244244
# add those to summary.txt and we're using it for extracting values
245245
echo "PASSED: ${passed} FAILED: ${failed} SKIPPED: ${skipped}" >> ${LOG_DIRECTORY}/summary.txt
246+
# send an error if there are any failed tests
247+
if [ ${failed} -gt 0 ]; then
248+
echo "Some tests failed. Check the logs in ${LOG_DIRECTORY} for details."
249+
exit 1
250+
else
251+
echo "All tests passed successfully."
252+
fi

.github/workflows/_ci.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ jobs:
623623
job-name: ${{ env.JOB_NAME }}
624624
- name: Download logs from S3
625625
id: log-s3
626+
if: ${{ !cancelled() }}
626627
run: |
627628
mkdir -p axlearn-output
628629
aws s3 cp s3://jax-toolbox-eks-output/axlearn/${{ github.run_id }}/logs/summary.txt axlearn-output/

0 commit comments

Comments
 (0)