Skip to content

Commit 94f09fe

Browse files
authored
Set default vocab_path in test-pax.sh (#784)
Automatically set the default `VOCAB_PATH` in `test-pax.sh` if not provided by the user. This eliminates the need for the user to pass in a vocab path that ultimately ends up being unused
1 parent b6aba18 commit 94f09fe

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/container/test-pax.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,7 @@ set -ex
372372
export XLA_PYTHON_CLIENT_MEM_FRACTION=${XLA_PYTHON_CLIENT_MEM_FRACTION:-0.65}
373373
export ENABLE_TE=$ENABLE_TE
374374
export NVTE_FUSED_ATTN=$NVTE_FUSED_ATTN
375+
export VOCAB_PATH=${VOCAB_PATH:-gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model}
375376

376377
if [[ ${MODEL_TYPE} == "126M" ]]; then
377378
CONFIG=ci_configs.Synthetic126MCI

.github/workflows/_test_pax_rosetta.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
9999
#SBATCH --time=00:30:00
100100
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
101-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
101+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
102102
103103
# preload enroot container using one task per node
104104
time srun \
@@ -319,7 +319,7 @@ jobs:
319319
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
320320
#SBATCH --time=00:30:00
321321
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
322-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
322+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
323323
324324
# preload enroot container using one task per node
325325
time srun \
@@ -516,7 +516,7 @@ jobs:
516516
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
517517
#SBATCH --time=00:30:00
518518
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
519-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
519+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
520520
521521
# preload enroot container using one task per node
522522
time srun \
@@ -708,7 +708,7 @@ jobs:
708708
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
709709
#SBATCH --time=00:30:00
710710
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
711-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
711+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
712712
713713
# preload enroot container using one task per node
714714
time srun \
@@ -900,7 +900,7 @@ jobs:
900900
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
901901
#SBATCH --time=00:30:00
902902
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
903-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
903+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
904904
905905
# preload enroot container using one task per node
906906
time srun \

.github/workflows/_test_upstream_pax.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ jobs:
9393
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
9494
#SBATCH --time=00:30:00
9595
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
96-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
97-
96+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
97+
9898
# preload enroot container using one task per node
9999
time srun \
100100
--ntasks-per-node=1 \
@@ -269,7 +269,7 @@ jobs:
269269
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
270270
#SBATCH --time=00:30:00
271271
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
272-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
272+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
273273
274274
# preload enroot container using one task per node
275275
time srun \
@@ -416,7 +416,7 @@ jobs:
416416
#SBATCH --gpus-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
417417
#SBATCH --time=00:30:00
418418
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
419-
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
419+
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
420420
421421
# preload enroot container using one task per node
422422
time srun \

0 commit comments

Comments
 (0)