Remove representative jobs from scenario info (#297)

Author: itsomri

pkg/scheduler/actions/common/solvers/scenario/base_scenario.go

@@ -114,19 +114,15 @@ func (s *BaseScenario) appendTasksAsVictimJob(tasks []*pod_info.PodInfo) {
 	s.victimsJobsTaskGroups[job.UID] = append(s.victimsJobsTaskGroups[job.UID], job)
 
 	victimTasks := make([]*pod_info.PodInfo, 0)
-	victimJobs := make([]*podgroup_info.PodGroupInfo, 0)
 	victim, found := s.victims[job.UID]
 	if found {
 		victimTasks = victim.Tasks
-		victimJobs = victim.RepresentativeJobs
 	}
 	victimTasks = append(victimTasks, tasks...)
-	victimJobs = append(victimJobs, job)
 
 	s.victims[job.UID] = &api.VictimInfo{
-		Job:                originalJob,
-		RepresentativeJobs: victimJobs,
-		Tasks:              victimTasks,
+		Job:   originalJob,
+		Tasks: victimTasks,
 	}
 }
 

pkg/scheduler/actions/consolidation/consolidation.go

@@ -117,11 +117,9 @@ func attemptToConsolidatePreemptor(
 
 func allPodsReallocated(scenario api.ScenarioInfo) bool {
 	for _, victim := range scenario.GetVictims() {
-		for _, job := range victim.RepresentativeJobs {
-			for _, task := range job.PodInfos {
-				if task.Status == pod_status.Releasing {
-					return false
-				}
+		for _, task := range victim.Tasks {
+			if task.Status == pod_status.Releasing {
+				return false
 			}
 		}
 	}

pkg/scheduler/api/scenario_info.go

@@ -17,8 +17,6 @@ type ScenarioInfo interface {
 type VictimInfo struct {
 	// Job is the original job that is being evicted, as it exists in the session
 	Job *podgroup_info.PodGroupInfo
-	// RepresentativeJob is a partial representation of the job that is being evicted. To be deprecated.
-	RepresentativeJobs []*podgroup_info.PodGroupInfo
-	// Tasks is the list of tasks that are being evicted.
+	// Tasks is the list of tasks that are being evicted, as they exist in the session
 	Tasks []*pod_info.PodInfo
 }