Skip to content

Add Normalize function#951

Merged
cliffburdick merged 15 commits into
NVIDIA:mainfrom
ahmedhus22:feat-normalizeop
Apr 25, 2025
Merged

Add Normalize function#951
cliffburdick merged 15 commits into
NVIDIA:mainfrom
ahmedhus22:feat-normalizeop

Conversation

@ahmedhus22
Copy link
Copy Markdown
Contributor

Closes #693

@cliffburdick
Copy link
Copy Markdown
Collaborator

/build

@ahmedhus22
Copy link
Copy Markdown
Contributor Author

should i add the license at the start of new source files or its not necessary?

@cliffburdick
Copy link
Copy Markdown
Collaborator

should i add the license at the start of new source files or its not necessary?

yes, please copy and paste from another file

Comment thread include/matx/operators/normalize.h Outdated
Comment thread include/matx/transforms/normalize.h Outdated
Comment thread docs_input/api/linalg/other/normalize.rst Outdated
Copy link
Copy Markdown
Collaborator

@cliffburdick cliffburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding this. I left a couple minor comments.

@ahmedhus22
Copy link
Copy Markdown
Contributor Author

Addressed the requested changes, and fixed an issue with NormalizeScale test where I was calculating stdd across the whole tensor, even though it is only normalized across 0th dimension.

@ahmedhus22 ahmedhus22 requested a review from cliffburdick April 25, 2025 07:49
@cliffburdick
Copy link
Copy Markdown
Collaborator

/build

@cliffburdick cliffburdick merged commit 117dc29 into NVIDIA:main Apr 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Add Normalize function

2 participants