Fix build error using shape_type in std::conditional_t#954
Merged
cliffburdick merged 1 commit intoApr 28, 2025
Merged
Conversation
Fixes issue GH-953. The conv1d operator uses std::conditional_t<> to define a local shape_type depending on the shape_type trait of the output operator. When combined with an output operator lacking a shape_type trait, this yields a build error. Relatively few operators include a public shape_type trait, although the tensor_desc_t struct does include shape_type. This commit removes public shape_type traits from current operators that define them, but does allow private shape_type types for internal use. For conv1d, shape_type is replaced by index_t. shape_type is still used in the tensor descriptors. Signed-off-by: Thomas Benson <tbenson@nvidia.com>
Collaborator
Author
|
/build |
cliffburdick
approved these changes
Apr 28, 2025
cliffburdick
deleted the
bugfix/remove-shape-type-dependency-in-std-conditional
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue GH-953. The conv1d operator uses std::conditional_t<> to define a local shape_type depending on the shape_type trait of the output operator. When combined with an output operator lacking a shape_type trait, this yields a build error.
Relatively few operators include a public shape_type trait, although the tensor_desc_t struct does include shape_type. This commit removes public shape_type traits from current operators that define them, but does allow private shape_type types for internal use. For conv1d, shape_type is replaced by index_t. shape_type is still used in the tensor descriptors.