Skip to content

Commit 088395f

Browse files
gdengkGao Deng
authored andcommitted
ADLR/megatron-lm!3340 - Fix the TE assertion for release
Co-authored-by: Gao Deng <gdeng@cw-dfw-cs-001-vscode-01.cm.cluster>
1 parent f98b1a0 commit 088395f

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

megatron/core/extensions/transformer_engine.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1355,13 +1355,13 @@ def fused_apply_rotary_pos_emb(
13551355
warnings.warn(
13561356
"transpose_output_memory is not supported by TE's fused RoPE and will be ignored."
13571357
)
1358-
if is_te_min_version("2.3.0.dev0"):
1358+
if is_te_min_version("2.2.0.dev0"):
13591359
return apply_rotary_pos_emb(
13601360
t, freqs, tensor_format="sbhd", interleaved=interleaved, fused=True
13611361
)
13621362
else:
13631363
if interleaved:
1364-
raise ValueError("Only TE >= 2.3.0.dev0 supports interleaved fused RoPE.")
1364+
raise ValueError("Only TE >= 2.2.0.dev0 supports interleaved fused RoPE.")
13651365
return apply_rotary_pos_emb(t, freqs, tensor_format="sbhd", fused=True)
13661366

13671367
def fused_apply_rotary_pos_emb_thd(

megatron/core/models/common/embeddings/rope_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ def apply_rotary_pos_emb(
211211
except ImportError:
212212
raise ImportError(
213213
"TE interleaved fused RoPE is not available."
214-
"Please install TE >= 2.3.0.dev0."
214+
"Please install TE >= 2.2.0.dev0."
215215
)
216216
else:
217217
assert (

megatron/core/transformer/transformer_config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -910,10 +910,10 @@ def __post_init__(self):
910910

911911
if self.apply_rope_fusion:
912912
if self.rotary_interleaved:
913-
if not is_te_min_version("2.3.0.dev0"):
913+
if not is_te_min_version("2.2.0.dev0"):
914914
raise ValueError(
915915
"rotary_interleaved does not work with apply_rope_fusion for "
916-
"TE < 2.3.0.dev0. Please install TE >= 2.3.0.dev0"
916+
"TE < 2.2.0.dev0. Please install TE >= 2.2.0.dev0"
917917
)
918918

919919
from megatron.core.models.common.embeddings.rope_utils import (

0 commit comments

Comments
 (0)