Skip to content

Commit ac198fc

Browse files
committed
Merge branch 'ko3n1g/chore/cherry-pick-3596' into 'core_r0.13.0'
Cherry-pick `!3596 - fix: Guard TE import` See merge request ADLR/megatron-lm!3666
2 parents aed679e + c602d89 commit ac198fc

14 files changed

Lines changed: 50 additions & 11 deletions

megatron/core/models/T5/t5_spec.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
from megatron.core.transformer.transformer_layer import TransformerLayer, TransformerLayerSubmodules
1717

1818
try:
19+
import transformer_engine as te # pylint: disable=unused-import
20+
1921
from megatron.core.extensions.transformer_engine import (
2022
TEColumnParallelLinear,
2123
TEDotProductAttention,

megatron/core/models/bert/bert_layer_specs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
from megatron.core.transformer.transformer_layer import TransformerLayer, TransformerLayerSubmodules
1313

1414
try:
15+
import transformer_engine as te # pylint: disable=unused-import
16+
1517
from megatron.core.extensions.transformer_engine import (
1618
TEDotProductAttention,
1719
TELayerNormColumnParallelLinear,

megatron/core/models/gpt/gpt_layer_specs.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434
)
3535

3636
try:
37+
import transformer_engine as te # pylint: disable=unused-import
38+
3739
from megatron.core.extensions.transformer_engine import TEFusedMLP, TENorm
3840
from megatron.core.extensions.transformer_engine_spec_provider import TESpecProvider
3941

@@ -42,6 +44,8 @@
4244
HAVE_TE = False
4345

4446
try:
47+
import nvidia_kitchen # pylint: disable=unused-import
48+
4549
from megatron.core.extensions.kitchen import KitchenSpecProvider
4650

4751
HAVE_KITCHEN = True

megatron/core/models/gpt/heterogeneous/heterogeneous_layer_specs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
from megatron.core.utils import is_te_min_version
3030

3131
try:
32+
import transformer_engine as te # pylint: disable=unused-import
33+
3234
from megatron.core.extensions.transformer_engine import (
3335
TEDotProductAttention,
3436
TELayerNormColumnParallelLinear,

megatron/core/models/gpt/moe_module_specs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
from megatron.core.transformer.spec_utils import ModuleSpec
1010

1111
try:
12+
import transformer_engine as te # pylint: disable=unused-import
13+
1214
from megatron.core.extensions.transformer_engine_spec_provider import TESpecProvider
1315

1416
HAVE_TE = True

megatron/core/models/retro/decoder_spec.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
HAVE_APEX = False
4141

4242
try:
43+
import transformer_engine as te # pylint: disable=unused-import
44+
4345
from megatron.core.extensions.transformer_engine import (
4446
TEColumnParallelLinear,
4547
TEDotProductAttention,

megatron/core/models/retro/encoder_spec.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
from megatron.core.transformer.transformer_block import TransformerBlockSubmodules
2222

2323
try:
24+
import transformer_engine as te # pylint: disable=unused-import
25+
2426
from megatron.core.extensions.transformer_engine import (
2527
TEColumnParallelLinear,
2628
TEDotProductAttention,

megatron/core/transformer/cuda_graphs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from megatron.core.utils import is_te_min_version
2424

2525
try:
26+
import transformer_engine as te # pylint: disable=unused-import
2627
from transformer_engine.pytorch.fp8 import FP8GlobalStateManager, fp8_autocast
2728
from transformer_engine.pytorch.graph import restore_fp8_tensors, save_fp8_tensors
2829
from transformer_engine.pytorch.graph import set_capture_end as te_set_capture_end

megatron/core/transformer/heterogeneous/linear_replacements.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
from megatron.core.utils import divide
1717

1818
try:
19+
import transformer_engine as te # pylint: disable=unused-import
20+
1921
from megatron.core.extensions.transformer_engine import TELayerNormColumnParallelLinear
2022

2123
HAVE_TE = True
@@ -67,6 +69,7 @@ def __init__(self, config: TransformerConfig, tp_comm_buffer_name: str, *args, *
6769
)
6870

6971
def forward(self, x, **kwargs):
72+
"""Forward of TELayerNormColumnParallelLinearGathered"""
7073
out, bias = super().forward(x)
7174
assert bias is None, "bias should be None since we set skip_bias_add=False"
7275

@@ -100,6 +103,7 @@ def forward(
100103
runtime_gather_output: bool | None = None,
101104
**kwargs,
102105
):
106+
"""Forward of ColumnParallelLinearGathered"""
103107
out, bias = super().forward(input_, weight, runtime_gather_output)
104108
assert bias is None, "bias should be None since we set skip_bias_add=False"
105109

megatron/core/transformer/moe/experts.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
)
4141

4242
try:
43+
import transformer_engine as te # pylint: disable=unused-import
4344

4445
from megatron.core.extensions.transformer_engine import Fp8Padding, Fp8Unpadding
4546

0 commit comments

Comments
 (0)