Skip to content

Fsdp dsv3 proxy#3844

Open
gautham-kollu wants to merge 24 commits intoNVIDIA:mainfrom
gautham-kollu:fsdp_dsv3_proxy
Open

Fsdp dsv3 proxy#3844
gautham-kollu wants to merge 24 commits intoNVIDIA:mainfrom
gautham-kollu:fsdp_dsv3_proxy

Conversation

@gautham-kollu
Copy link
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: gkollu <gkollu@nvidia.com>
Signed-off-by: gkollu <gkollu@nvidia.com>
Signed-off-by: gkollu <gkollu@nvidia.com>
Signed-off-by: gkollu <gkollu@nvidia.com>
Signed-off-by: gkollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@gautham-kollu gautham-kollu marked this pull request as ready for review March 12, 2026 23:19
@gautham-kollu gautham-kollu requested a review from a team as a code owner March 12, 2026 23:19
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 12, 2026 23:20
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
@gautham-kollu
Copy link
Contributor Author

/ok to test d607e1f

@gautham-kollu
Copy link
Contributor Author

/ok to test d607e1f

@gautham-kollu
Copy link
Contributor Author

/ok to test 8b6363a

- test_case: [deepseek_proxy_fsdp_ep2_fsdp2]
products:
- environment: [dev]
scope: [mr, mr-github, weekly]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if think either mr, mr-github or weekly is good - we dont need both (if they run per mr, they will pass on weekly); we should run per mr unless its too big of a test

@shjwudp shjwudp requested a review from xuwchen March 13, 2026 10:48
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
1
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
1
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Signed-off-by: Gautham Kollu <gkollu@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants