Skip to content

ci: Skip more tests in test_vision_cuda_graphs for LTS#3860

Merged
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/skip-test-vision-cuda-graph
Mar 13, 2026
Merged

ci: Skip more tests in test_vision_cuda_graphs for LTS#3860
chtruong814 merged 1 commit intoNVIDIA:mainfrom
chtruong814:chtruong/skip-test-vision-cuda-graph

Conversation

@chtruong814
Copy link
Contributor

What does this PR do ?

ci: Skip more tests in test_vision_cuda_graphs for LTS

We missed some additional unit tests to skip. We had previously skipped some tests in the dev CI run. But these same tests should also be skipped in the LTS CI run. The tests never passed as part of CI because they only activated for TE 2.13, which we only just bumped to in the past few days.

Issue for following-up to fix these tests:
#3804

PR to bump to TE 2.13:
#3800

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft March 13, 2026 16:07
@github-actions
Copy link
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 13, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Copy link
Contributor

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@chtruong814 chtruong814 marked this pull request as ready for review March 13, 2026 17:12
@chtruong814
Copy link
Contributor Author

Fast merging to resolve test issues.

@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 13, 2026 17:12
@chtruong814 chtruong814 merged commit 8a806e5 into NVIDIA:main Mar 13, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants