Pass gracefully if token_id not found in message#3862
Open
i-riyad wants to merge 1 commit intoNVIDIA:mainfrom
Open
Pass gracefully if token_id not found in message#3862i-riyad wants to merge 1 commit intoNVIDIA:mainfrom
i-riyad wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: rislam <rislam@nvidia.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
i-riyad
changed the title
santhnm2
approved these changes
Mar 13, 2026
Comment on lines
+295
to
+297
| logger.warning( | ||
| "Last assistant message missing prompt_token_ids/" | ||
| "generation_token_ids; skipping prefix replacement." |
Contributor
There was a problem hiding this comment.
To confirm, this else branch does not necessarily represent a failure and this is expected?
Contributor
Author
There was a problem hiding this comment.
Yes. This is what I had to do instead of assert.
| from megatron.core.inference.contexts import BaseInferenceContext | ||
| from megatron.core.packed_seq_params import PackedSeqParams | ||
| from megatron.core.process_groups_config import ProcessGroupCollection | ||
| from megatron.core.transformer.cuda_graphs import _CudagraphGlobalRecord |
Contributor
There was a problem hiding this comment.
Is this change still necessary? Same for the change in transformer_layer.py
Contributor
Author
There was a problem hiding this comment.
I will rebase, this will go away.
kvareddy
approved these changes
Mar 13, 2026
5 tasks
shanmugamr1992
approved these changes
Mar 14, 2026
svcnvidia-nemo-ci
added
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.