Skip to content

Commit a487a07

Browse files
Jianbo Liunvidia-bfigg
authored andcommitted
net/mlx5e: Support FEC settings for 200G per lane link modes
BugLink: https://bugs.launchpad.net/bugs/2126973 Add support to show and config FEC by ethtool for 200G/lane link modes. The RS encoding setting is mapped, and can be overridden to FEC_RS_544_514_INTERLEAVED_QUAD for these modes. Signed-off-by: Jianbo Liu <jianbol@nvidia.com> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com> Signed-off-by: Tariq Toukan <tariqt@nvidia.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com> (cherry picked from commit 4e343c1) Signed-off-by: Lama Kayal <lkayal@nvidia.com> Acked-by: Carol L Soto <csoto@nvidia.com> Acked-by: Matthew R. Ochs <mochs@nvidia.com> Acked-by: Tushar Dave <tdave@nvidia.com> Acked-by: Jamie Nguyen <jamien@nvidia.com> Acked-by: Nirmoy Das <nirmoyd@nvidia.com> Acked-by: Noah Wager <noah.wager@canonical.com> Acked-by: Jacob Martin <jacob.martin@canonical.com> Signed-off--by: Brad Figg <bfigg@nvidia.com>
1 parent ee7420f commit a487a07

File tree

3 files changed

+56
-10
lines changed

3 files changed

+56
-10
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/port.c

Lines changed: 54 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -296,11 +296,16 @@ enum mlx5e_fec_supported_link_mode {
296296
MLX5E_FEC_SUPPORTED_LINK_MODE_200G_2X,
297297
MLX5E_FEC_SUPPORTED_LINK_MODE_400G_4X,
298298
MLX5E_FEC_SUPPORTED_LINK_MODE_800G_8X,
299+
MLX5E_FEC_SUPPORTED_LINK_MODE_200G_1X,
300+
MLX5E_FEC_SUPPORTED_LINK_MODE_400G_2X,
301+
MLX5E_FEC_SUPPORTED_LINK_MODE_800G_4X,
302+
MLX5E_FEC_SUPPORTED_LINK_MODE_1600G_8X,
299303
MLX5E_MAX_FEC_SUPPORTED_LINK_MODE,
300304
};
301305

302306
#define MLX5E_FEC_FIRST_50G_PER_LANE_MODE MLX5E_FEC_SUPPORTED_LINK_MODE_50G_1X
303307
#define MLX5E_FEC_FIRST_100G_PER_LANE_MODE MLX5E_FEC_SUPPORTED_LINK_MODE_100G_1X
308+
#define MLX5E_FEC_FIRST_200G_PER_LANE_MODE MLX5E_FEC_SUPPORTED_LINK_MODE_200G_1X
304309

305310
#define MLX5E_FEC_OVERRIDE_ADMIN_POLICY(buf, policy, write, link) \
306311
do { \
@@ -320,8 +325,10 @@ static bool mlx5e_is_fec_supported_link_mode(struct mlx5_core_dev *dev,
320325
return link_mode < MLX5E_FEC_FIRST_50G_PER_LANE_MODE ||
321326
(link_mode < MLX5E_FEC_FIRST_100G_PER_LANE_MODE &&
322327
MLX5_CAP_PCAM_FEATURE(dev, fec_50G_per_lane_in_pplm)) ||
323-
(link_mode >= MLX5E_FEC_FIRST_100G_PER_LANE_MODE &&
324-
MLX5_CAP_PCAM_FEATURE(dev, fec_100G_per_lane_in_pplm));
328+
(link_mode < MLX5E_FEC_FIRST_200G_PER_LANE_MODE &&
329+
MLX5_CAP_PCAM_FEATURE(dev, fec_100G_per_lane_in_pplm)) ||
330+
(link_mode >= MLX5E_FEC_FIRST_200G_PER_LANE_MODE &&
331+
MLX5_CAP_PCAM_FEATURE(dev, fec_200G_per_lane_in_pplm));
325332
}
326333

327334
/* get/set FEC admin field for a given speed */
@@ -368,6 +375,18 @@ static int mlx5e_fec_admin_field(u32 *pplm, u16 *fec_policy, bool write,
368375
case MLX5E_FEC_SUPPORTED_LINK_MODE_800G_8X:
369376
MLX5E_FEC_OVERRIDE_ADMIN_POLICY(pplm, *fec_policy, write, 800g_8x);
370377
break;
378+
case MLX5E_FEC_SUPPORTED_LINK_MODE_200G_1X:
379+
MLX5E_FEC_OVERRIDE_ADMIN_POLICY(pplm, *fec_policy, write, 200g_1x);
380+
break;
381+
case MLX5E_FEC_SUPPORTED_LINK_MODE_400G_2X:
382+
MLX5E_FEC_OVERRIDE_ADMIN_POLICY(pplm, *fec_policy, write, 400g_2x);
383+
break;
384+
case MLX5E_FEC_SUPPORTED_LINK_MODE_800G_4X:
385+
MLX5E_FEC_OVERRIDE_ADMIN_POLICY(pplm, *fec_policy, write, 800g_4x);
386+
break;
387+
case MLX5E_FEC_SUPPORTED_LINK_MODE_1600G_8X:
388+
MLX5E_FEC_OVERRIDE_ADMIN_POLICY(pplm, *fec_policy, write, 1600g_8x);
389+
break;
371390
default:
372391
return -EINVAL;
373392
}
@@ -421,6 +440,18 @@ static int mlx5e_get_fec_cap_field(u32 *pplm, u16 *fec_cap,
421440
case MLX5E_FEC_SUPPORTED_LINK_MODE_800G_8X:
422441
*fec_cap = MLX5E_GET_FEC_OVERRIDE_CAP(pplm, 800g_8x);
423442
break;
443+
case MLX5E_FEC_SUPPORTED_LINK_MODE_200G_1X:
444+
*fec_cap = MLX5E_GET_FEC_OVERRIDE_CAP(pplm, 200g_1x);
445+
break;
446+
case MLX5E_FEC_SUPPORTED_LINK_MODE_400G_2X:
447+
*fec_cap = MLX5E_GET_FEC_OVERRIDE_CAP(pplm, 400g_2x);
448+
break;
449+
case MLX5E_FEC_SUPPORTED_LINK_MODE_800G_4X:
450+
*fec_cap = MLX5E_GET_FEC_OVERRIDE_CAP(pplm, 800g_4x);
451+
break;
452+
case MLX5E_FEC_SUPPORTED_LINK_MODE_1600G_8X:
453+
*fec_cap = MLX5E_GET_FEC_OVERRIDE_CAP(pplm, 1600g_8x);
454+
break;
424455
default:
425456
return -EINVAL;
426457
}
@@ -494,6 +525,26 @@ int mlx5e_get_fec_mode(struct mlx5_core_dev *dev, u32 *fec_mode_active,
494525
return 0;
495526
}
496527

528+
static u16 mlx5e_remap_fec_conf_mode(enum mlx5e_fec_supported_link_mode link_mode,
529+
u16 conf_fec)
530+
{
531+
/* RS fec in ethtool is originally mapped to MLX5E_FEC_RS_528_514.
532+
* For link modes up to 25G per lane, the value is kept.
533+
* For 50G or 100G per lane, it's remapped to MLX5E_FEC_RS_544_514.
534+
* For 200G per lane, remapped to MLX5E_FEC_RS_544_514_INTERLEAVED_QUAD.
535+
*/
536+
if (conf_fec != BIT(MLX5E_FEC_RS_528_514))
537+
return conf_fec;
538+
539+
if (link_mode >= MLX5E_FEC_FIRST_200G_PER_LANE_MODE)
540+
return BIT(MLX5E_FEC_RS_544_514_INTERLEAVED_QUAD);
541+
542+
if (link_mode >= MLX5E_FEC_FIRST_50G_PER_LANE_MODE)
543+
return BIT(MLX5E_FEC_RS_544_514);
544+
545+
return conf_fec;
546+
}
547+
497548
int mlx5e_set_fec_mode(struct mlx5_core_dev *dev, u16 fec_policy)
498549
{
499550
bool fec_50g_per_lane = MLX5_CAP_PCAM_FEATURE(dev, fec_50G_per_lane_in_pplm);
@@ -530,14 +581,7 @@ int mlx5e_set_fec_mode(struct mlx5_core_dev *dev, u16 fec_policy)
530581
if (!mlx5e_is_fec_supported_link_mode(dev, i))
531582
break;
532583

533-
/* RS fec in ethtool is mapped to MLX5E_FEC_RS_528_514
534-
* to link modes up to 25G per lane and to
535-
* MLX5E_FEC_RS_544_514 in the new link modes based on
536-
* 50G or 100G per lane
537-
*/
538-
if (conf_fec == (1 << MLX5E_FEC_RS_528_514) &&
539-
i >= MLX5E_FEC_FIRST_50G_PER_LANE_MODE)
540-
conf_fec = (1 << MLX5E_FEC_RS_544_514);
584+
conf_fec = mlx5e_remap_fec_conf_mode(i, conf_fec);
541585

542586
mlx5e_get_fec_cap_field(out, &fec_caps, i);
543587

drivers/net/ethernet/mellanox/mlx5/core/en/port.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ enum {
6161
MLX5E_FEC_NOFEC,
6262
MLX5E_FEC_FIRECODE,
6363
MLX5E_FEC_RS_528_514,
64+
MLX5E_FEC_RS_544_514_INTERLEAVED_QUAD = 4,
6465
MLX5E_FEC_RS_544_514 = 7,
6566
MLX5E_FEC_LLRS_272_257_1 = 9,
6667
};

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,7 @@ static const u32 pplm_fec_2_ethtool[] = {
952952
[MLX5E_FEC_RS_528_514] = ETHTOOL_FEC_RS,
953953
[MLX5E_FEC_RS_544_514] = ETHTOOL_FEC_RS,
954954
[MLX5E_FEC_LLRS_272_257_1] = ETHTOOL_FEC_LLRS,
955+
[MLX5E_FEC_RS_544_514_INTERLEAVED_QUAD] = ETHTOOL_FEC_RS,
955956
};
956957

957958
static u32 pplm2ethtool_fec(u_long fec_mode, unsigned long size)

0 commit comments

Comments
 (0)