Skip to content

Commit aa19d6c

Browse files
committed
fix: incorporate review comments
1 parent 13ffb72 commit aa19d6c

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

health-monitors/syslog-health-monitor/pkg/common/common.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ func MapActionStringToProto(s string) pb.RecommendedAction {
8282
// RECOVER_FEATURE_RESET_GPU: power-smoothing feature recovery (XID 163);
8383
// trigger guidance is "reload the driver or reset the GPU" — same proto
8484
// target as the RESET_GPU bucket.
85-
case "WORKFLOW_XID_48", "RESET_GPU", "RESET_FABRIC", "RECOVER_FEATURE_RESET_GPU":
85+
case "WORKFLOW_XID_48", "RESET_GPU", "RECOVER_FEATURE_RESET_GPU":
8686
return pb.RecommendedAction_COMPONENT_RESET
8787
// WORKFLOW_XID_168: WPR/ECC config issue (XID 168). Catalog guidance is
8888
// "either ECC should be enabled (to enable row-remapping) or boot
8989
// re-attempted with shifted WPR" — reboot the VM so init can re-attempt
9090
// with a shifted Write-Protect-Region.
91-
case "WORKFLOW_XID_168":
91+
case "WORKFLOW_XID_168", "RESET_FABRIC":
9292
return pb.RecommendedAction_RESTART_VM
9393
default:
9494
slog.Warn("Unknown action string, defaulting to CONTACT_SUPPORT", "action", s)

health-monitors/syslog-health-monitor/pkg/common/common_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,6 @@ func TestMapActionStringToProto(t *testing.T) {
101101
input: "RESET_GPU",
102102
expectedOutput: pb.RecommendedAction_COMPONENT_RESET,
103103
},
104-
{
105-
input: "RESET_FABRIC",
106-
expectedOutput: pb.RecommendedAction_COMPONENT_RESET,
107-
},
108104
{
109105
input: "RECOVER_FEATURE_RESET_GPU",
110106
expectedOutput: pb.RecommendedAction_COMPONENT_RESET,
@@ -113,6 +109,10 @@ func TestMapActionStringToProto(t *testing.T) {
113109
input: "WORKFLOW_XID_168",
114110
expectedOutput: pb.RecommendedAction_RESTART_VM,
115111
},
112+
{
113+
input: "RESET_FABRIC",
114+
expectedOutput: pb.RecommendedAction_RESTART_VM,
115+
},
116116
{
117117
input: "NONE",
118118
expectedOutput: pb.RecommendedAction_NONE,

0 commit comments

Comments
 (0)