refactor(cli): share file-backed plugin activation

Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>

Author: bbednarski9

crates/cli/src/commands/mod.rs

@@ -225,6 +225,8 @@ async fn run_default(
         )?;
         server::serve_with_dynamic(
             resolved.gateway,
+            resolved.plugin_had_input,
+            resolved.plugin_diagnostics,
             dynamic_plugins,
             managed_bootstrap,
             runtime_args.ready_file.as_deref(),

crates/cli/src/configuration/mod.rs

@@ -260,6 +260,7 @@ fn persistent_bootstrap_fingerprint(
         "max_hook_payload_bytes": gateway.max_hook_payload_bytes,
         "max_passthrough_body_bytes": gateway.max_passthrough_body_bytes,
         "plugin_idle_timeout_secs": idle_timeout_secs,
+        "plugin_had_input": resolved.plugin_had_input,
         "dynamic_plugins": dynamic_plugins,
         "dynamic_plugin_policy": format!("{:?}", resolved.dynamic_plugin_policy),
     });
@@ -1301,6 +1302,8 @@ struct PluginTomlConfig {
     dynamic_plugin_policy: DynamicPluginHostPolicy,
     contributing_sources: Vec<PathBuf>,
     selected_sources: Vec<PathBuf>,
+    had_input: bool,
+    diagnostics: Vec<nemo_relay::plugin::ConfigDiagnostic>,
 }
 
 #[cfg(test)]
@@ -1410,6 +1413,8 @@ where
         dynamic_plugin_policy: resolved.dynamic_plugin_policy,
         contributing_sources,
         selected_sources: resolved.selected_sources,
+        had_input: resolved.had_input,
+        diagnostics: resolved.diagnostics,
     }))
 }
 
@@ -1423,6 +1428,8 @@ fn apply_plugin_toml_config(resolved: &mut ResolvedConfig, plugin_toml: Option<P
     resolved.dynamic_plugins = plugin_toml.dynamic_plugins;
     resolved.dynamic_plugin_policy = plugin_toml.dynamic_plugin_policy;
     resolved.plugin_selected_sources = plugin_toml.selected_sources;
+    resolved.plugin_had_input = plugin_toml.had_input;
+    resolved.plugin_diagnostics = plugin_toml.diagnostics;
 }
 
 #[cfg(test)]

crates/cli/src/configuration/types.rs

@@ -8,6 +8,7 @@ use std::path::PathBuf;
 
 use axum::http::HeaderMap;
 use nemo_relay::logging::LoggingConfig;
+use nemo_relay::plugin::ConfigDiagnostic;
 use serde::Serialize;
 use serde_json::{Map, Value};
 use strum::{Display, IntoStaticStr};
@@ -64,6 +65,8 @@ pub(crate) struct ResolvedConfig {
     pub(crate) dynamic_plugins: Vec<ResolvedDynamicPluginConfig>,
     pub(crate) dynamic_plugin_policy: DynamicPluginHostPolicy,
     pub(crate) plugin_selected_sources: Vec<PathBuf>,
+    pub(crate) plugin_had_input: bool,
+    pub(crate) plugin_diagnostics: Vec<ConfigDiagnostic>,
     pub(crate) bootstrap_fingerprint: Option<String>,
 }
 

crates/cli/src/process/launcher.rs

@@ -9,7 +9,7 @@ use nemo_relay::observability::OpenTelemetryType;
 use nemo_relay::observability::plugin_component::{
     AtifStorageConfig, AtofSinkSectionConfig, OBSERVABILITY_PLUGIN_KIND, ObservabilityConfig,
 };
-use nemo_relay::plugin::PluginConfig;
+use nemo_relay::plugin::{ConfigDiagnostic, PluginConfig};
 use serde_json::Value;
 #[cfg(test)]
 use serde_json::json;
@@ -137,6 +137,8 @@ impl TransparentRun {
         let result = execute_live_run_with_dynamic(
             self.listener,
             self.resolved.gateway,
+            self.resolved.plugin_had_input,
+            self.resolved.plugin_diagnostics,
             self.dynamic_plugins,
             &self.gateway_url,
             self.prepared,
@@ -178,12 +180,23 @@ async fn execute_live_run(
     gateway_url: &str,
     prepared: PreparedAgentLaunch,
 ) -> Result<ExitCode, CliError> {
-    execute_live_run_with_dynamic(listener, gateway_config, Vec::new(), gateway_url, prepared).await
+    execute_live_run_with_dynamic(
+        listener,
+        gateway_config,
+        false,
+        Vec::new(),
+        Vec::new(),
+        gateway_url,
+        prepared,
+    )
+    .await
 }
 
 async fn execute_live_run_with_dynamic(
     listener: TcpListener,
     gateway_config: GatewayConfig,
+    plugin_had_input: bool,
+    plugin_diagnostics: Vec<ConfigDiagnostic>,
     dynamic_plugins: Vec<ActiveDynamicPluginComponent>,
     gateway_url: &str,
     prepared: PreparedAgentLaunch,
@@ -193,6 +206,8 @@ async fn execute_live_run_with_dynamic(
     let running_server = RunningGateway::start(
         listener,
         gateway_config,
+        plugin_had_input,
+        plugin_diagnostics,
         dynamic_plugins,
         bootstrap_fingerprint.clone(),
         proxy_credential,
@@ -365,6 +380,8 @@ impl RunningGateway {
     fn start(
         listener: TcpListener,
         config: crate::configuration::GatewayConfig,
+        plugin_had_input: bool,
+        plugin_diagnostics: Vec<ConfigDiagnostic>,
         dynamic_plugins: Vec<ActiveDynamicPluginComponent>,
         bootstrap_fingerprint: String,
         proxy_credential: crate::provider_auth::TransparentProxyCredential,
@@ -374,6 +391,8 @@ impl RunningGateway {
             server::serve_transparent_listener_with_dynamic(
                 listener,
                 config,
+                plugin_had_input,
+                plugin_diagnostics,
                 dynamic_plugins,
                 bootstrap_fingerprint,
                 proxy_credential,