test(e2e): retain Brev readiness failure evidence

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>

Author: jyaunches

test/e2e/fixtures/brev-launchable.ts

@@ -194,17 +194,29 @@ export class BrevLaunchableFixture {
     timeoutMs = DEFAULT_BREV_EXEC_READY_TIMEOUT_MS,
   ): Promise<void> {
     const deadline = Date.now() + timeoutMs;
+    let attempts = 0;
+    let lastResult: ShellProbeResult | undefined;
     while (Date.now() < deadline) {
+      attempts += 1;
       const remaining = deadline - Date.now();
       const result = await this.exec(ownership, "true", {
         artifactName: "brev-exec-readiness",
         persistArtifacts: false,
         timeoutMs: Math.min(30_000, remaining),
       });
       if (result.exitCode === 0) return;
+      lastResult = result;
       await delay(Math.min(this.pollMs, Math.max(1, deadline - Date.now())));
     }
-    throw new Error("Brev exec readiness timed out");
+    await this.artifacts.writeJson("brev-exec-readiness-failure.json", {
+      attempts,
+      lastResult,
+      workspaceId: ownership.id,
+      workspaceName: ownership.name,
+    });
+    throw new Error(
+      `Brev exec readiness timed out after ${attempts} attempts: ${lastResult ? resultText(lastResult) : "no command result"}`,
+    );
   }
 
   private async exec(

test/e2e/support/brev-launchable-fixture.test.ts

@@ -293,6 +293,25 @@ describe("the Brev Launchable fixture binds staging identity and workspace lifec
     expect(ownership.id).toBe("owned-id");
   });
 
+  it("records the last failed Brev exec readiness attempt", async () => {
+    const root = temporaryRoot();
+    const command = vi.fn(ownedExecCommand("", 1, "ssh unavailable"));
+    const fixture = createFixture(root, command);
+
+    await expect(fixture.waitForExec(recordedOwnership(), 10)).rejects.toThrow(
+      "Brev exec readiness timed out",
+    );
+    const evidence = JSON.parse(
+      fs.readFileSync(path.join(root, "brev-exec-readiness-failure.json"), "utf8"),
+    );
+    expect(evidence).toMatchObject({
+      attempts: expect.any(Number),
+      lastResult: { exitCode: 1, stderr: "ssh unavailable" },
+      workspaceId: "owned-id",
+      workspaceName: "fixture-workspace",
+    });
+  });
+
   it("refuses a replacement before Brev exec readiness without executing on it", async () => {
     const root = temporaryRoot();
     const lifecycle = replaceableWorkspaceCommand();
@@ -496,13 +515,15 @@ function recordedOwnership(): BrevWorkspaceOwnership {
 
 function ownedExecCommand(
   stdout: string,
+  exitCode = 0,
+  stderr = "",
 ): (_binary: string, args: string[], _options?: ShellProbeRunOptions) => Promise<ShellProbeResult> {
   return async (_binary, args, _options) => {
     switch (args[0]) {
       case "ls":
         return workspaceResult("owned-id");
       case "exec":
-        return result(stdout);
+        return { ...result(stdout), exitCode, stderr };
       default:
         throw new Error(`unexpected command: ${args.join(" ")}`);
     }