Skip to content

Commit 8380b0f

Browse files
jiaenrenclaude
andcommitted
test(oetf): keep the labels scenario deployment-neutral
Use the reserved example.com domain for the pod_label_prefix case and drop deployment-specific references from the comments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent d0b557e commit 8380b0f

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

test/scenarios/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ oetf_scenario_test(
7979
# end-to-end labeled run). Serial + exclusive because the policy tests mutate
8080
# the shared labels_config; each restores the baseline in tearDown. `kind` =
8181
# runs in the `oetf:deploy_and_run --env kind` CI gate. The heavier lifecycle
82-
# and ConfigMap-fixture matrix runs on dev/Orin, not here.
82+
# and ConfigMap-fixture matrix runs elsewhere, not here.
8383
oetf_scenario_test(
8484
name = "workflow-labels",
8585
src = "workflow_labels.py",

test/scenarios/workflow_labels.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# in-cluster kubeconfig). It covers the per-key policy gate (off / warn /
1616
# enforce), label-syntax validation, list filtering, and one real end-to-end
1717
# labeled workflow run. Literal pod-object label assertions are covered by the
18-
# `apply_workflow_labels` unit tests and dev/Orin runs, not here.
18+
# `apply_workflow_labels` unit tests, not here.
1919

2020
import os
2121
import secrets
@@ -27,8 +27,8 @@
2727
from test.oetf.runner_fixture import RunnerFixture
2828

2929
# A stable value set for the curated `PPP` key. `aurora` doubles as a value the
30-
# end-to-end run submits, so it must be accepted by any pre-existing allow-list
31-
# on the target (the NVIDIA dev fixture allows aurora/borealis/cosmos).
30+
# end-to-end run submits, so it must be accepted by whatever allow-list the
31+
# target deployment configures for `PPP`.
3232
ALLOWED_PPP_VALUES = ["aurora", "borealis", "cosmos"]
3333
DISALLOWED_PPP_VALUE = "drift"
3434

@@ -315,7 +315,7 @@ def test_labeled_workflow_labels_round_trip(self) -> None:
315315
# by apply_pod_label_prefix, not observable from a sandboxed OETF). ─────
316316

317317
def test_pod_label_prefix_gates_merge_and_keeps_api_keys_bare(self) -> None:
318-
prefix = "osmo.nvidia.com/"
318+
prefix = "example.com/"
319319
self._set_pod_label_prefix(prefix)
320320

321321
# A bare key forms a valid Kubernetes key once the prefix is prepended.

test/scenarios/workflow_labels.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
# Portable workflow-labels spec. Platform is omitted by default so the pool's
1212
# server-side default applies (works on the KIND quick-start pool); set
13-
# OETF_DEFAULT_PLATFORM to pin one on dev/Orin. A quick echo task keeps the
14-
# end-to-end run fast.
13+
# OETF_DEFAULT_PLATFORM to pin one where the pool requires it. A quick echo
14+
# task keeps the end-to-end run fast.
1515

1616
version: 2
1717
workflow:

0 commit comments

Comments
 (0)