[None][chore] Update flashinfer-python from 0.6.11.post1 to 0.6.12rc1#14512
[None][chore] Update flashinfer-python from 0.6.11.post1 to 0.6.12rc1#14512yihwang-nv wants to merge 1 commit into
Conversation
Bump flashinfer-python dependency to the v0.6.12rc1 release candidate. The wheel is not yet published to PyPI, so requirements.txt pins to the GitHub tag via a git+https URL. Updated version pins in requirements.txt, security_scanning/pyproject.toml, and ATTRIBUTIONS-Python.md. Signed-off-by: yihwang-nv <yihwang@nvidia.com>
|
/bot run --disable-fail-fast --add-multi-gpu-test |
📝 WalkthroughWalkthroughThis PR updates the ChangesDependency Version Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@requirements.txt`:
- Line 57: Replace the mutable tag in the requirements entry for
flashinfer-python with the full commit SHA to ensure reproducible installs:
locate the line containing "flashinfer-python @
git+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1#egg=flashinfer-python"
and change the ref after the @ to the immutable commit
"529e592e9d8c5677b25c3cb38358bbd4def6c6dd" so it reads the same URL but with
"`@529e592e9d8c5677b25c3cb38358bbd4def6c6dd`" instead of "`@v0.6.12rc1`".
In `@security_scanning/pyproject.toml`:
- Line 57: The pyproject pin for the dependency "flashinfer-python
(==0.6.12rc1)" is out of sync with the lockfile which still records
0.6.11.post1; regenerate or update the lockfile so both declare the same
version: either change the pyproject constraint to match the lockfile or run the
dependency manager's lock/update command to produce a poetry.lock that contains
flashinfer-python==0.6.12rc1, then commit the updated lockfile to ensure
scanners read consistent metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fb28b5ac-7611-4a92-b5d3-88c272aa7e47
📒 Files selected for processing (3)
ATTRIBUTIONS-Python.mdrequirements.txtsecurity_scanning/pyproject.toml
| patchelf | ||
| einops | ||
| flashinfer-python==0.6.11.post1 | ||
| flashinfer-python @ git+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1#egg=flashinfer-python |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify current tag target and whether requirements.txt uses an immutable SHA.
set -euo pipefail
echo "Resolving flashinfer tag:"
git ls-remote https://github.com/flashinfer-ai/flashinfer.git refs/tags/v0.6.12rc1
echo
echo "Current flashinfer requirement line:"
rg -n '^flashinfer-python\s+@\s+git\+https://github.com/flashinfer-ai/flashinfer.git@' requirements.txtRepository: NVIDIA/TensorRT-LLM
Length of output: 297
Pin flashinfer-python to an immutable commit SHA
requirements.txt currently pins flashinfer-python to the mutable tag @v0.6.12rc1 (tag currently points to 529e592e9d8c5677b25c3cb38358bbd4def6c6dd). Pin the full commit SHA for reproducibility and supply-chain integrity.
Suggested update
-flashinfer-python @ git+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1#egg=flashinfer-python
+flashinfer-python @ git+https://github.com/flashinfer-ai/flashinfer.git@529e592e9d8c5677b25c3cb38358bbd4def6c6dd#egg=flashinfer-python📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| flashinfer-python @ git+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1#egg=flashinfer-python | |
| flashinfer-python @ git+https://github.com/flashinfer-ai/flashinfer.git@529e592e9d8c5677b25c3cb38358bbd4def6c6dd#egg=flashinfer-python |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@requirements.txt` at line 57, Replace the mutable tag in the requirements
entry for flashinfer-python with the full commit SHA to ensure reproducible
installs: locate the line containing "flashinfer-python @
git+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1#egg=flashinfer-python"
and change the ref after the @ to the immutable commit
"529e592e9d8c5677b25c3cb38358bbd4def6c6dd" so it reads the same URL but with
"`@529e592e9d8c5677b25c3cb38358bbd4def6c6dd`" instead of "`@v0.6.12rc1`".
| "patchelf (>=0.17.2.4,<0.18.0.0)", | ||
| "einops (>=0.8.2,<0.9.0)", | ||
| "flashinfer-python (==0.6.11.post1)", | ||
| "flashinfer-python (==0.6.12rc1)", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify pyproject/lock mismatch for flashinfer-python in security_scanning inputs.
set -euo pipefail
echo "pyproject dependency:"
rg -n 'flashinfer-python' security_scanning/pyproject.toml
echo
echo "poetry.lock package stanza:"
rg -n -A6 -B2 'name = "flashinfer-python"' security_scanning/poetry.lockRepository: NVIDIA/TensorRT-LLM
Length of output: 402
Align flashinfer-python version between security_scanning/pyproject.toml and security_scanning/poetry.lock
security_scanning/pyproject.toml pins "flashinfer-python (==0.6.12rc1)", while security_scanning/poetry.lock still lists flashinfer-python as 0.6.11.post1. Update/regenerate security_scanning/poetry.lock (or ensure the security scanner uses the same dependency source) to prevent stale version metadata during scans.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@security_scanning/pyproject.toml` at line 57, The pyproject pin for the
dependency "flashinfer-python (==0.6.12rc1)" is out of sync with the lockfile
which still records 0.6.11.post1; regenerate or update the lockfile so both
declare the same version: either change the pyproject constraint to match the
lockfile or run the dependency manager's lock/update command to produce a
poetry.lock that contains flashinfer-python==0.6.12rc1, then commit the updated
lockfile to ensure scanners read consistent metadata.
|
PR_Github #50142 [ run ] triggered by Bot. Commit: |
|
PR_Github #50142 [ run ] completed with state
|
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #50226 [ run ] triggered by Bot. Commit: |
2 participants
Summary
requirements.txtpins to the GitHub tag viagit+https://github.com/flashinfer-ai/flashinfer.git@v0.6.12rc1requirements.txt,security_scanning/pyproject.toml, andATTRIBUTIONS-Python.mdsecurity_scanning/poetry.lockintentionally left untouched (RC has no PyPI hashes); maintainers regenerate it separatelyTest plan
pip install -r requirements.txtinstalls successfully (requires building flashinfer from source)pytest tests/unittest/_torch/flashinfer/ -vpytest tests/unittest/_torch/attention/test_flashinfer_attention.py -vSummary by CodeRabbit