fix(qwen3.8): satisfy repository contracts and formatting

Community CPU failed on the previous head. Three unrelated causes.

clang-format rejected three sites introduced by the review fixes: a boolean
chain in Qwen38KvCache::ok(), the POSIX headers added to plugin_helpers.cpp for
the kernel staging change, and the open() call in that same function. The C++
sources are now formatted with the version CI runs.

The HF reference sidecar carried the bare term "qwen" in a comment naming this
module's own dotted import path. That term is reserved to the qwen_vl family by
test_hf_transformers_model_plugins_do_not_name_sibling_families, and the qwen3_5
sidecar contains no occurrence of it either. The comment now refers to the
module without naming the path.

Adding a family shifts repository-wide counters that several contract tests
assert exactly. All of them are bumped by one for qwen3_8 and its qwen38-27b
profile, relative to the current main:

  test_family_specialization  families                        85 -> 86
  test_trtmc_validate         catalog models / ready models  117 -> 118
                              validation bindings            118 -> 119
                              dataset-backed binding models  117 -> 118
  test_perf_matrix            release suite cases            110 -> 111
                              release raw entries             80 -> 81
                              family/operation pairs          80 -> 81
                              distinct families               78 -> 79
                              public_pipeline_call_wall       85 -> 86
                              consolidated result rows       110 -> 111

test_repository_contracts delegates to the validate and perf-matrix checks, so
it passes once those counts are correct.

These counters were stale from the first commit of this branch, not from the
review fixes. The earlier local runs covered only four test files and none of
these; the full set now passes.

Validation on one NVIDIA SM 10.0 device with TensorRT 11.1.0.106:
clang-format --dry-run --Werror is clean over every qwen3_8 C++ source; ruff,
tools/legal_headers.py and tools/check_doc_file_references.py are clean; the
eight contract and family test files plus the qwen3_5 regression pass 663/663;
and ctest -R qwen3_8 passes 3/3.

Signed-off-by: Zhenshan Xie <zhenshanx@nvidia.com>

Author: zhenshanx-nv

src/runtime/models/qwen3_8/kv_cache.cpp

@@ -387,8 +387,7 @@ bool Qwen38KvCache::ok() const {
         }
         return true;
     };
-    return group_ok(cache_k_) && group_ok(cache_v_) && group_ok(present_k_) &&
-           group_ok(present_v_);
+    return group_ok(cache_k_) && group_ok(cache_v_) && group_ok(present_k_) && group_ok(present_v_);
 }
 
 } // namespace trtmc

src/runtime/models/qwen3_8/plugin_helpers.cpp

@@ -12,15 +12,14 @@
 #include <chrono>
 #include <cstring>
 #include <fcntl.h>
-#include <sys/stat.h>
-#include <unistd.h>
-
 #include <fstream>
 #include <iomanip>
 #include <iostream>
 #include <sstream>
 #include <stdexcept>
 #include <string_view>
+#include <sys/stat.h>
+#include <unistd.h>
 #include <utility>
 
 #if TRTMC_HAS_TVM_FFI
@@ -439,7 +438,8 @@ std::string write_kernel_so_to_temp(const std::string& global_name, const char*
         return {};
 
     std::string tmp_path = std::string(dir_buf.data()) + "/" + safe_name + ".so";
-    const int fd = ::open(tmp_path.c_str(), O_WRONLY | O_CREAT | O_EXCL | O_NOFOLLOW, S_IRUSR | S_IWUSR);
+    const int fd =
+        ::open(tmp_path.c_str(), O_WRONLY | O_CREAT | O_EXCL | O_NOFOLLOW, S_IRUSR | S_IWUSR);
     if (fd < 0) {
         ::rmdir(dir_buf.data());
         return {};

tests/e2e/models/qwen3_8/e2e_plugins/references/hf_transformers.py

@@ -204,9 +204,9 @@ def _reference_env(ctx: RunContext) -> dict[str, str]:
     env = dict(os.environ)
     if ctx.ld_library_path:
         env["LD_LIBRARY_PATH"] = ctx.ld_library_path
-    # The child imports tests.e2e.models.qwen3_8.e2e_plugins.references, so the
-    # repository root has to be importable even when the parent process runs
-    # from another directory. Existing entries are preserved.
+    # The child imports this module by its full dotted path, so the repository
+    # root has to be importable even when the parent process runs from another
+    # directory. Existing entries are preserved.
     project_dir = str(PROJECT_DIR)
     existing = env.get("PYTHONPATH", "")
     parts = [p for p in existing.split(os.pathsep) if p]

tests/tools/test_family_specialization.py

@@ -404,7 +404,7 @@ def test_repository_registers_all_current_families() -> None:
 
     families = specialization.family_dirs(repo_root, ())
 
-    assert len(families) == 85
+    assert len(families) == 86
     assert any(family.name == "cosmos3" for family in families)
     assert any(family.name == "dinov3" for family in families)
     assert any(family.name == "fast_foundation_stereo" for family in families)

tests/tools/test_perf_matrix.py

@@ -270,8 +270,8 @@ def test_release_suite_covers_every_non_l0_ready_model_profile() -> None:
 
     performance_catalog.validate_release_coverage(cases, excluded_profiles)
 
-    assert len(cases) == 110
-    assert len(raw_entries) == 80
+    assert len(cases) == 111
+    assert len(raw_entries) == 81
     assert len(raw_additional) == 30
     assert excluded_profiles == {
         "lfm2-1.2b": LFM2_EXCLUSION_REASON,
@@ -289,15 +289,15 @@ def test_release_suite_covers_every_non_l0_ready_model_profile() -> None:
     assert not any("priority" in entry for entry in raw_entries)
     assert {case["model"] for case in cases} == ready_profiles - set(excluded_profiles)
     assert not any(performance_catalog.is_l0_profile(case["model"]) for case in cases)
-    assert len({(case["family"], case["operation"]) for case in cases}) == 80
-    assert len({case["family"] for case in cases}) == 78
+    assert len({(case["family"], case["operation"]) for case in cases}) == 81
+    assert len({case["family"] for case in cases}) == 79
     assert [case["operation"] for case in cases if case["family"] == "eagle_vlm"] == [
         "embed",
         "rerank",
     ]
     assert Counter(perf_matrix._candidate_timing_scope(case) for case in cases) == {
         "model_call_wall": 25,
-        "public_pipeline_call_wall": 85,
+        "public_pipeline_call_wall": 86,
     }
     assert {case["id"] for case in cases if case["baseline"]["asset_loading_included"]} == {
         "canary.transcribe",
@@ -2191,7 +2191,7 @@ def preflight_after_pending_report(cases, options):
     assert not scratch_root.exists()
     results = json.loads((output / "results.json").read_text(encoding="utf-8"))
     rows = {row["id"]: row for row in results["cases"]}
-    assert len(rows) == 110
+    assert len(rows) == 111
     assert results["environment_config"]["name"] == "test-gb300"
     assert results["environment_config"]["execution"]["minimum_gpu_free_fraction"] == 0.0
     assert results["environment_config"]["source"] == str(environment.resolve())

tests/tools/test_trtmc_validate.py

@@ -45,7 +45,7 @@ def test_model_workload_catalog_covers_every_ready_model():
         task_models=task_models,
     )
 
-    assert len(catalog["models"]) == len(ready_models) == 117
+    assert len(catalog["models"]) == len(ready_models) == 118
     assert sum("not_compared_reason" in spec for spec in catalog["models"].values()) == 0
     assert all("e2e" not in spec.get("workloads", []) for spec in catalog["models"].values())
     assert "reference_cache_identity" not in catalog["models"]["personaplex-7b"]
@@ -64,7 +64,7 @@ def test_model_workload_catalog_covers_every_ready_model():
     }
     assert len(qwen_identities) == 1
     bindings = trtmc_validate.resolve_bindings(catalog, catalog["models"])
-    assert len(bindings) == 118
+    assert len(bindings) == 119
     assert {
         binding.model for binding in bindings if binding.workload == "mmlu_continuation_parity"
     } >= {
@@ -255,7 +255,7 @@ def test_every_dataset_backed_validation_binding_has_native_reference_runner():
             missing.append((model_name, workload, dataset_kind))
 
     assert not missing
-    assert len({model for model, _workload in bindings}) == 117
+    assert len({model for model, _workload in bindings}) == 118
 
 
 def test_shadow_gate_metrics_include_plugin_task_accuracy() -> None: