add ability to delete parameters in tsd UI

Author: jeffamstutz

tsd/apps/interactive/common/tsd_ui.cpp

@@ -135,6 +135,14 @@ static void buildUI_parameter_contextMenu(Context &ctx, Parameter *p)
       ImGui::EndMenu(); // "set type"
     }
 
+    ImGui::Separator();
+
+    if (ImGui::BeginMenu("delete?")) {
+      if (ImGui::MenuItem("yes"))
+        p->remove();
+      ImGui::EndMenu(); // "delete?"
+    }
+
     ImGui::EndPopup();
   }
 }
@@ -435,7 +443,7 @@ void buildUI_parameter(tsd::Parameter &p, tsd::Context &ctx, bool useTable)
   if (update)
     p.setValue(pVal);
 
-  buildUI_parameter_contextMenu(ctx, &p);
+  buildUI_parameter_contextMenu(ctx, &p); // NOTE: 'p' can be deleted after this
 
   ImGui::PopID();
 }

tsd/src/tsd/core/Object.cpp

@@ -209,6 +209,11 @@ void Object::parameterChanged(const Parameter *p)
     m_updateDelegate->signalParameterUpdated(this, p);
 }
 
+void Object::removeParameter(const Parameter *p)
+{
+  removeParameter(p->name());
+}
+
 BaseUpdateDelegate *Object::updateDelegate() const
 {
   return m_updateDelegate;

tsd/src/tsd/core/Object.hpp

@@ -105,6 +105,7 @@ struct Object : public ParameterObserver
 
  protected:
   virtual void parameterChanged(const Parameter *p) override;
+  virtual void removeParameter(const Parameter *p) override;
   BaseUpdateDelegate *updateDelegate() const;
 
  private:

tsd/src/tsd/core/Parameter.cpp

@@ -9,6 +9,12 @@ Parameter::Parameter(ParameterObserver *object, Token name)
     : m_observer(object), m_name(name)
 {}
 
+void Parameter::remove()
+{
+  if (m_observer)
+    m_observer->removeParameter(this);
+}
+
 Token Parameter::name() const
 {
   return m_name;

tsd/src/tsd/core/Parameter.hpp

@@ -26,12 +26,15 @@ struct Parameter;
 struct ParameterObserver
 {
   virtual void parameterChanged(const Parameter *p) = 0;
+  virtual void removeParameter(const Parameter *p) = 0;
 };
 
 struct Parameter
 {
   Parameter(ParameterObserver *object, Token name);
 
+  void remove(); // remove (and delete) parameter from parent object
+
   Token name() const;
   const std::string &description() const;
 

tsd/tests/test_Parameter.cpp

@@ -15,6 +15,11 @@ struct MockObject : public tsd::ParameterObserver
     notified = true;
   }
 
+  void removeParameter(const tsd::Parameter *) override
+  {
+    // no-op
+  }
+
   bool notified{false};
 };