Skip to content

Commit 6893e35

Browse files
committed
CI: Run linting checks on PRs as they use hosted runners and remove old redundant PR signature comment workflow.
1 parent 992714a commit 6893e35

File tree

5 files changed

+15
-131
lines changed

5 files changed

+15
-131
lines changed

.github/workflows/pr-signature-comment.yml

Lines changed: 0 additions & 123 deletions
This file was deleted.

.github/workflows/test-git-lfs.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
push:
55
branches:
66
- '**'
7-
# pull_request is not supported for this workflow due to self-hosted runners
8-
# see the "Reviewing PRs from forks" section in CONTRIBUTING.md for more details
7+
pull_request_target:
8+
types: [opened, reopened, synchronize]
99

1010
jobs:
1111
test-git-lfs:
@@ -14,6 +14,8 @@ jobs:
1414
steps:
1515
- name: Checkout repository
1616
uses: actions/checkout@v4
17+
with:
18+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
1719

1820
- name: Check that binary files are tracked by LFS
1921
id: git-lfs-check

.github/workflows/test-git-signatures.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
push:
55
branches:
66
- '**'
7-
# pull_request is not supported for this workflow due to self-hosted runners
8-
# see the "Reviewing PRs from forks" section in CONTRIBUTING.md for more details
7+
pull_request_target:
8+
types: [opened, reopened, synchronize]
99

1010
jobs:
1111
test-git-signatures:
@@ -16,6 +16,7 @@ jobs:
1616
uses: actions/checkout@v4
1717
with:
1818
fetch-depth: 0 # Need full history to compare with main
19+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
1920

2021
- name: Check commit signatures
2122
id: github-api-signature-check

.github/workflows/test-links.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
push:
55
branches:
66
- '**'
7-
# pull_request is not supported for this workflow due to self-hosted runners
8-
# see the "Reviewing PRs from forks" section in CONTRIBUTING.md for more details
7+
pull_request_target:
8+
types: [opened, reopened, synchronize]
99

1010
jobs:
1111
test-links:
@@ -14,6 +14,8 @@ jobs:
1414
steps:
1515
- name: Checkout repository
1616
uses: actions/checkout@v4
17+
with:
18+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
1719

1820
- name: Set up Python
1921
uses: actions/setup-python@v5

.github/workflows/test-yaml.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
push:
55
branches:
66
- '**'
7-
# pull_request is not supported for this workflow due to self-hosted runners
8-
# see the "Reviewing PRs from forks" section in CONTRIBUTING.md for more details
7+
pull_request_target:
8+
types: [opened, reopened, synchronize]
99

1010
jobs:
1111
test-yaml:
@@ -14,6 +14,8 @@ jobs:
1414
steps:
1515
- name: Checkout repository
1616
uses: actions/checkout@v4
17+
with:
18+
ref: ${{ github.event.pull_request.head.sha || github.sha }}
1719

1820
- name: Set up Python
1921
uses: actions/setup-python@v5

0 commit comments

Comments
 (0)