fix: use validator.PhaseDeployment constant in tests

Replace string literal "deployment" with validator.PhaseDeployment
to fix goconst lint error in CI.

Author: mchmarny

pkg/validator/checks/deployment/expected_resources_check_unit_test.go

@@ -20,6 +20,7 @@ import (
 	"testing"
 
 	"github.com/NVIDIA/aicr/pkg/recipe"
+	"github.com/NVIDIA/aicr/pkg/validator"
 	"github.com/NVIDIA/aicr/pkg/validator/checks"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -443,8 +444,8 @@ func TestValidateExpectedResourcesRegistration(t *testing.T) {
 		t.Errorf("Name = %v, want expected-resources", check.Name)
 	}
 
-	if check.Phase != "deployment" {
-		t.Errorf("Phase = %v, want deployment", check.Phase)
+	if check.Phase != string(validator.PhaseDeployment) {
+		t.Errorf("Phase = %v, want %v", check.Phase, validator.PhaseDeployment)
 	}
 
 	if check.Description == "" {

pkg/validator/checks/deployment/helm_values_check_unit_test.go

@@ -22,6 +22,7 @@ import (
 	"github.com/NVIDIA/aicr/pkg/measurement"
 	"github.com/NVIDIA/aicr/pkg/recipe"
 	"github.com/NVIDIA/aicr/pkg/snapshotter"
+	"github.com/NVIDIA/aicr/pkg/validator"
 	"github.com/NVIDIA/aicr/pkg/validator/checks"
 )
 
@@ -319,8 +320,8 @@ func TestCheckHelmValuesRegistration(t *testing.T) {
 		t.Errorf("Name = %v, want helm-values", check.Name)
 	}
 
-	if check.Phase != "deployment" { //nolint:goconst // test literal
-		t.Errorf("Phase = %v, want deployment", check.Phase)
+	if check.Phase != string(validator.PhaseDeployment) {
+		t.Errorf("Phase = %v, want %v", check.Phase, validator.PhaseDeployment)
 	}
 
 	if check.Description == "" {