refactor: rename PreDeployment to Readiness across codebase and docs

Author: xdu31

docs/user/cli-reference.md

@@ -542,7 +542,7 @@ eidos validate \
   --kubeconfig ~/.kube/prod-cluster
 ```
 
-**Output Structure (Pre-Deployment Phase):**
+**Output Structure (Readiness Phase):**
 ```yaml
 apiVersion: eidos.nvidia.com/v1alpha1
 kind: ValidationResult
@@ -590,10 +590,10 @@ metadata:
 recipeSource: recipe.yaml
 snapshotSource: snapshot.yaml
 summary:
-  passed: 10
+  passed: 3
   failed: 0
-  skipped: 0
-  total: 10
+  skipped: 1
+  total: 4
   status: pass
   duration: 58.4µs
 phases:

pkg/recipe/metadata.go

@@ -127,8 +127,8 @@ type ExpectedResource struct {
 
 // ValidationConfig defines validation phases and settings.
 type ValidationConfig struct {
-	// PreDeployment defines pre-deployment validation phase settings.
-	PreDeployment *ValidationPhase `json:"preDeployment,omitempty" yaml:"preDeployment,omitempty"`
+	// Readiness defines readiness validation phase settings.
+	Readiness *ValidationPhase `json:"readiness,omitempty" yaml:"readiness,omitempty"`
 
 	// Deployment defines deployment validation phase settings.
 	Deployment *ValidationPhase `json:"deployment,omitempty" yaml:"deployment,omitempty"`
@@ -377,8 +377,8 @@ func (s *RecipeMetadataSpec) Merge(other *RecipeMetadataSpec) {
 		if s.Validation == nil {
 			s.Validation = other.Validation
 		} else {
-			if other.Validation.PreDeployment != nil {
-				s.Validation.PreDeployment = other.Validation.PreDeployment
+			if other.Validation.Readiness != nil {
+				s.Validation.Readiness = other.Validation.Readiness
 			}
 			if other.Validation.Deployment != nil {
 				s.Validation.Deployment = other.Validation.Deployment

pkg/recipe/metadata_test.go

@@ -487,7 +487,7 @@ func TestMergeValidationConfig(t *testing.T) {
 	t.Run("overlay phases merge with base", func(t *testing.T) {
 		base := RecipeMetadataSpec{
 			Validation: &ValidationConfig{
-				PreDeployment: &ValidationPhase{
+				Readiness: &ValidationPhase{
 					Checks: []string{"gpu-hardware-detection"},
 				},
 				Deployment: &ValidationPhase{
@@ -513,11 +513,11 @@ func TestMergeValidationConfig(t *testing.T) {
 		if base.Validation == nil {
 			t.Fatal("validation should not be nil after merge")
 		}
-		if base.Validation.PreDeployment == nil {
-			t.Fatal("preDeployment should be preserved from base")
+		if base.Validation.Readiness == nil {
+			t.Fatal("readiness should be preserved from base")
 		}
-		if base.Validation.PreDeployment.Checks[0] != "gpu-hardware-detection" {
-			t.Error("preDeployment checks should be preserved from base")
+		if base.Validation.Readiness.Checks[0] != "gpu-hardware-detection" {
+			t.Error("readiness checks should be preserved from base")
 		}
 		if base.Validation.Deployment.Timeout != "10m" {
 			t.Errorf("deployment timeout = %q, want 10m (from overlay)", base.Validation.Deployment.Timeout)

pkg/validator/checks/runner.go

@@ -156,9 +156,9 @@ func (r *TestRunner) HasCheck(phase, checkName string) bool {
 
 	var checkList []string
 	switch phase {
-	case "readiness", "preDeployment":
-		if r.ctx.Recipe.Validation.PreDeployment != nil {
-			checkList = r.ctx.Recipe.Validation.PreDeployment.Checks
+	case "readiness":
+		if r.ctx.Recipe.Validation.Readiness != nil {
+			checkList = r.ctx.Recipe.Validation.Readiness.Checks
 		}
 	case "deployment":
 		if r.ctx.Recipe.Validation.Deployment != nil {

pkg/validator/checks/runner_test.go

@@ -360,7 +360,7 @@ func TestLoadValidationContext_InvalidRecipeData(t *testing.T) {
 func TestTestRunner_HasCheck(t *testing.T) {
 	recipeResult := &recipe.RecipeResult{
 		Validation: &recipe.ValidationConfig{
-			PreDeployment: &recipe.ValidationPhase{
+			Readiness: &recipe.ValidationPhase{
 				Checks: []string{"gpu-hardware-detection"},
 			},
 			Deployment: &recipe.ValidationPhase{
@@ -392,7 +392,6 @@ func TestTestRunner_HasCheck(t *testing.T) {
 		want      bool
 	}{
 		{"readiness phase has check", "readiness", "gpu-hardware-detection", true},
-		{"preDeployment alias", "preDeployment", "gpu-hardware-detection", true},
 		{"readiness phase missing check", "readiness", "nonexistent", false},
 		{"deployment phase has check", "deployment", "operator-health", true},
 		{"deployment phase has second check", "deployment", "check-nvidia-smi", true},

pkg/validator/phases.go

@@ -293,10 +293,10 @@ func (v *Validator) validateReadiness(
 	// For multi-phase validation, validateAll() manages RBAC lifecycle.
 	// For single-phase validation, the CLI/API should call agent.EnsureRBAC() first.
 	//nolint:dupl // Phase validation methods have similar structure by design
-	if recipeResult.Validation != nil && recipeResult.Validation.PreDeployment != nil && len(recipeResult.Validation.PreDeployment.Checks) > 0 {
+	if recipeResult.Validation != nil && recipeResult.Validation.Readiness != nil && len(recipeResult.Validation.Readiness.Checks) > 0 {
 		if v.NoCluster {
 			slog.Info("no-cluster mode enabled, skipping cluster check execution for readiness phase")
-			for _, checkName := range recipeResult.Validation.PreDeployment.Checks {
+			for _, checkName := range recipeResult.Validation.Readiness.Checks {
 				check := CheckResult{
 					Name:   checkName,
 					Status: ValidationStatusPass,
@@ -310,9 +310,9 @@ func (v *Validator) validateReadiness(
 				// If Kubernetes is not available (e.g., running in test mode), skip check execution
 				slog.Warn("Kubernetes client unavailable, skipping check execution",
 					"error", err,
-					"checks", len(recipeResult.Validation.PreDeployment.Checks))
+					"checks", len(recipeResult.Validation.Readiness.Checks))
 				// Add skeleton check results
-				for _, checkName := range recipeResult.Validation.PreDeployment.Checks {
+				for _, checkName := range recipeResult.Validation.Readiness.Checks {
 					check := CheckResult{
 						Name:   checkName,
 						Status: ValidationStatusPass,
@@ -336,7 +336,7 @@ func (v *Validator) validateReadiness(
 					RecipeConfigMap:    recipeCMName,
 					TestPackage:        "./pkg/validator/checks/readiness",
 					TestPattern:        "", // Run all tests in package
-					Timeout:            resolvePhaseTimeout(recipeResult.Validation.PreDeployment, DefaultReadinessTimeout),
+					Timeout:            resolvePhaseTimeout(recipeResult.Validation.Readiness, DefaultReadinessTimeout),
 				}
 
 				deployer := agent.NewDeployer(clientset, jobConfig)

pkg/validator/phases_test.go

@@ -108,7 +108,7 @@ func TestValidatePhase(t *testing.T) {
 	}
 }
 
-func TestValidatePreDeployment(t *testing.T) {
+func TestValidateReadiness(t *testing.T) {
 	// Skip if running with -short flag (for fast unit tests)
 	if testing.Short() {
 		t.Skip("Skipping integration test in short mode")
@@ -136,7 +136,7 @@ func TestValidatePreDeployment(t *testing.T) {
 				{Name: "OS.release.ID", Value: "ubuntu"},
 			},
 			validationConfig: &recipe.ValidationConfig{
-				PreDeployment: &recipe.ValidationPhase{
+				Readiness: &recipe.ValidationPhase{
 					Checks: []string{"gpu-hardware-detection", "kernel-parameters"},
 				},
 			},
@@ -445,8 +445,8 @@ func TestValidateAll_PhaseOrder(t *testing.T) {
 	}
 
 	// Verify readiness has constraint results
-	preDeployPhase := result.Phases["readiness"]
-	if len(preDeployPhase.Constraints) == 0 {
+	readinessPhase := result.Phases["readiness"]
+	if len(readinessPhase.Constraints) == 0 {
 		t.Error("readiness phase should have constraint results")
 	}
 
@@ -540,7 +540,7 @@ func createTestRecipeWithValidation() *recipe.RecipeResult {
 			{Name: "OS.release.ID", Value: "ubuntu"},
 		},
 		Validation: &recipe.ValidationConfig{
-			PreDeployment: &recipe.ValidationPhase{
+			Readiness: &recipe.ValidationPhase{
 				Checks: []string{"gpu-hardware-detection", "kernel-parameters", "os-prerequisites"},
 			},
 			Deployment: &recipe.ValidationPhase{
@@ -1018,7 +1018,7 @@ func TestValidateRecipeRegistrations(t *testing.T) {
 			name: "readiness - no constraint validators to check",
 			recipe: &recipe.RecipeResult{
 				Validation: &recipe.ValidationConfig{
-					PreDeployment: &recipe.ValidationPhase{
+					Readiness: &recipe.ValidationPhase{
 						Checks: []string{"gpu-hardware-detection"},
 					},
 				},