Skip to content

Commit 8550939

Browse files
authored
fix(install): cosign version grep fails silently due to pipefail (#384)
1 parent d802b3d commit 8550939

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

.github/workflows/qualification.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ jobs:
8585

8686
cli-e2e:
8787
name: CLI E2E
88-
if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name != 'pull_request'
8988
runs-on: ubuntu-latest
9089
timeout-minutes: 15
9190
permissions:

install

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ main() {
261261
# Optional: verify attestation if cosign is available
262262
COSIGN_MIN_VERSION="v3.0.4"
263263
if command -v cosign &>/dev/null && [[ -f "${temp_dir}/${BIN_NAME}-attestation.sigstore.json" ]]; then
264-
cosign_version=$(cosign version --json 2>/dev/null | grep -o '"gitVersion":"[^"]*"' | cut -d'"' -f4)
264+
cosign_version=$(cosign version --json 2>/dev/null | grep -o '"gitVersion":[[:space:]]*"[^"]*"' | cut -d'"' -f4) || true
265265
if [[ -z "$cosign_version" ]]; then
266266
# Fallback: try text output
267267
cosign_version=$(cosign version 2>/dev/null | grep -i 'gitversion' | grep -oE 'v[0-9]+\.[0-9]+\.[0-9]+')

0 commit comments

Comments
 (0)