operator: update GOLANGCI_LINT_VERSION to v2.11.4

Signed-off-by: Ryan Koo <rbk65@cornell.edu>

Author: rkoo19

operator/Makefile

@@ -313,7 +313,7 @@ CERT_MANAGER_VERSION ?= v1.19.3
 CLOUD_PROVIDER_KIND_VERSION ?= v0.10.0
 CONTROLLER_TOOLS_VERSION ?= v0.20.0
 ENVTEST_VERSION ?= release-0.23
-GOLANGCI_LINT_VERSION ?= v2.10.1
+GOLANGCI_LINT_VERSION ?= v2.11.4
 GOMPLATE_VERSION ?= v5.0.0
 HELM_VERSION ?= v3.20.0
 HELMIFY_VERSION ?= v0.4.19

operator/api/v1beta1/aistore_webhook.go

@@ -85,29 +85,35 @@ func (ais *AIStore) validateAutoScaling() (admission.Warnings, error) {
 }
 
 func (ss *ServiceSpec) validate(path *field.Path) field.ErrorList {
-	allErrs := field.ErrorList{}
+	svcMsgs := validation.IsValidPortNum(ss.ServicePort.IntValue())
+	pubMsgs := validation.IsValidPortNum(ss.PublicPort.IntValue())
+	ctrlMsgs := validation.IsValidPortNum(ss.IntraControlPort.IntValue())
+	dataMsgs := validation.IsValidPortNum(ss.IntraDataPort.IntValue())
 
-	for _, msg := range validation.IsValidPortNum(ss.ServicePort.IntValue()) {
+	allErrs := make(field.ErrorList, 0, len(svcMsgs)+len(pubMsgs)+len(ctrlMsgs)+len(dataMsgs))
+	for _, msg := range svcMsgs {
 		allErrs = append(allErrs, field.Invalid(path.Child("servicePort"), ss.ServicePort.IntValue(), msg))
 	}
-	for _, msg := range validation.IsValidPortNum(ss.PublicPort.IntValue()) {
+	for _, msg := range pubMsgs {
 		allErrs = append(allErrs, field.Invalid(path.Child("portPublic"), ss.PublicPort.IntValue(), msg))
 	}
-	for _, msg := range validation.IsValidPortNum(ss.IntraControlPort.IntValue()) {
+	for _, msg := range ctrlMsgs {
 		allErrs = append(allErrs, field.Invalid(path.Child("portIntraControl"), ss.IntraControlPort.IntValue(), msg))
 	}
-	for _, msg := range validation.IsValidPortNum(ss.IntraDataPort.IntValue()) {
+	for _, msg := range dataMsgs {
 		allErrs = append(allErrs, field.Invalid(path.Child("portIntraData"), ss.IntraDataPort.IntValue(), msg))
 	}
 
 	return allErrs
 }
 
 func (ais *AIStore) validateServiceSpec() (admission.Warnings, error) {
-	allErrs := field.ErrorList{}
+	proxyErrs := ais.Spec.ProxySpec.validate(field.NewPath("spec", "proxySpec"))
+	targetErrs := ais.Spec.TargetSpec.validate(field.NewPath("spec", "targetSpec"))
 
-	allErrs = append(allErrs, ais.Spec.ProxySpec.validate(field.NewPath("spec", "proxySpec"))...)
-	allErrs = append(allErrs, ais.Spec.TargetSpec.validate(field.NewPath("spec", "targetSpec"))...)
+	allErrs := make(field.ErrorList, 0, len(proxyErrs)+len(targetErrs))
+	allErrs = append(allErrs, proxyErrs...)
+	allErrs = append(allErrs, targetErrs...)
 
 	return nil, allErrs.ToAggregate()
 }