Skip to content

Commit 6d21676

Browse files
committed
add commit_sha
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
1 parent f3663e4 commit 6d21676

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

.github/workflows/convergence-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
run: |
6060
lep login -c "$LEP_LOGIN_CREDENTIALS" || true
6161
if [ -n "${{ inputs.config_override }}" ]; then
62-
python ci/lepton/model_convergence/scripts/launch_job.py --config-name="${{ inputs.config_override }}.yaml" branch="${{ inputs.branch }}" commit_sha="${{ inputs.commit_sha }}"
62+
python ci/lepton/model_convergence/scripts/launch_job.py --config-name="${{ inputs.config_override }}.yaml" branch="${{ inputs.branch }}" +commit_sha="${{ inputs.commit_sha }}"
6363
else
64-
python ci/lepton/model_convergence/scripts/launch_job.py --config-name="recipes/${{ inputs.model_config }}" branch="${{ inputs.branch }}" commit_sha="${{ inputs.commit_sha }}"
64+
python ci/lepton/model_convergence/scripts/launch_job.py --config-name="recipes/${{ inputs.model_config }}" branch="${{ inputs.branch }}" +commit_sha="${{ inputs.commit_sha }}"
6565
fi

ci/lepton/model_convergence/configs/recipes/amplify_accelerate_te_fp8.yaml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,12 @@ dashboard_info:
1414
# Base configuration
1515
recipe_subdir: amplify_accelerate_te_fp8
1616
branch: jwilber/add-wandb-recipe-amplify
17+
commit_sha: ""
1718
train_cmnd: train
1819

1920
wandb_init_args:
21+
project: "amplify_accelerate_te_fp8"
22+
group: "recipes_model_convergence"
2023
mode: "online" # need online to collect logs; if offline, must manually sync after run
2124

2225
stop_after_n_steps: 10
@@ -33,14 +36,20 @@ products:
3336

3437
script: |
3538
git clone https://github.com/NVIDIA/bionemo-framework.git
36-
if [ "${branch}" != "main" ]; then
37-
cd bionemo-framework
39+
cd bionemo-framework
40+
if [ -n "${commit_sha}" ]; then
41+
echo "Checking out commit: ${commit_sha}"
42+
git checkout "${commit_sha}"
43+
elif [ "${branch}" != "main" ]; then
44+
echo "Checking out branch: ${branch}"
3845
git checkout "${branch}"
39-
cd ..
4046
fi
47+
cd ..
4148
cd bionemo-framework/recipes/${recipe_subdir}
4249
pip install -r requirements.txt
4350
torchrun ${train_cmnd}.py \
4451
--config-name ${config}.yaml \
45-
stop_after_n_steps=${stop_after_n_steps} \
46-
trainer.report_to=${trainer.report_to}
52+
trainer.report_to=${trainer.report_to} \
53+
wandb_init_args.mode=${wandb_init_args.mode} \
54+
wandb_init_args.project=${wandb_init_args.project} \
55+
+wandb_init_args.group=${wandb_init_args.group} \

0 commit comments

Comments
 (0)