Commit fe8d7e6
authored
unskip evo2 tests (#1058)
### Description
- This PR addresses issue
#1013
- In NeMo NVIDIA-NeMo/NeMo#14515, the code was
updated to reduce memory consumption
- This PR updates the NeMo version to 7ccb0d4.
- This PR adjusts the memory thresholds to skip tests in
sub-packages/bionemo-evo2/tests/bionemo/evo2/test_evo2.py
- This PR adds some tools for torch memory usage.
<!-- Provide a detailed description of the changes in this PR -->
### Type of changes
<!-- Mark the relevant option with an [x] -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Refactor
- [ ] Documentation update
- [ ] Other (please describe):
### CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
-
[SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci)
- Skip all continuous integration tests
-
[INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests)
- Execute notebook validation tests in pytest
-
[INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests)
- Execute tests labelled as slow in pytest for extensive testing
> [!NOTE]
> By default, the notebooks validation tests are skipped unless
explicitly enabled.
#### Authorizing CI Runs
We use
[copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation)
to manage authorization of CI
runs on NVIDIA's compute resources.
- If a pull request is opened by a trusted user and contains only
trusted changes, the pull request's code will
automatically be copied to a pull-request/ prefixed branch in the source
repository (e.g. pull-request/123)
- If a pull request is opened by an untrusted user or contains untrusted
changes, an NVIDIA org member must leave an
`/ok to test` comment on the pull request to trigger CI. This will need
to be done for each new commit.
### Usage
<!--- How does a user interact with the changed code -->
```python
# TODO: Add code snippet
```
### Pre-submit Checklist
<!--- Ensure all items are completed before submitting -->
- [x] I have tested these changes locally
- [x] I have updated the documentation accordingly
- [x] I have added/updated tests as needed
- [ ] All existing tests pass successfully
### Local test runs
the slow test
**test_evo2.py::test_golden_values_top_k_logits_and_cosine_similarity_7b**
is broken on **main**, will be marked skip
- (1 )
test_evo2.py::test_golden_values_top_k_logits_and_cosine_similarity_7b
is broken on this commit with **NVIDIA H100 80GB HBM3**
-
[pytests_pr1058_unskip_evo2_tests_sub-packages-bionemo-evo2-tests-bionemo-evo2-test_evo2_20250821T0024_6e2a005d.log](https://github.com/user-attachments/files/21922792/pytests_pr1058_unskip_evo2_tests_sub-packages-bionemo-evo2-tests-bionemo-evo2-test_evo2_20250821T0024_6e2a005d.log)
- (2) The same test as in (1) is broken on the commit *424050d2* in main
with *NVIDIA H100 80GB HBM3*
[pytests_pr1058_unskip_evo2_tests_sub-packages-bionemo-evo2-tests-bionemo-evo2-test_evo2__test_golden_values_top_k_logits_and_cosine_similarity_7b_20250821T2114_main_424050d2.log](https://github.com/user-attachments/files/21926382/pytests_pr1058_unskip_evo2_tests_sub-packages-bionemo-evo2-tests-bionemo-evo2-test_evo2__test_golden_values_top_k_logits_and_cosine_similarity_7b_20250821T2114_main_424050d2.log)
the slow test **test_evo.py::test_generate_speed** is marked skip per
https://nvidia.slack.com/archives/C074Z808N05/p1755185565520729?thread_ts=1755097791.370249&cid=C074Z808N05
---------
Signed-off-by: Brian Roland <broland@nvidia.com>1 parent 1f65287 commit fe8d7e6
File tree
5 files changed
+115
-34
lines changed- 3rdparty
- sub-packages
- bionemo-evo2/tests/bionemo/evo2
- bionemo-testing
- src/bionemo/testing
- tests/bionemo/testing
5 files changed
+115
-34
lines changedSubmodule NeMo updated from f4f22a2 to 7ccb0d4
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
28 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
29 | 36 | | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
39 | 47 | | |
40 | 48 | | |
41 | 49 | | |
| |||
Lines changed: 58 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
51 | 89 | | |
52 | 90 | | |
53 | 91 | | |
| |||
152 | 190 | | |
153 | 191 | | |
154 | 192 | | |
| 193 | + | |
155 | 194 | | |
156 | 195 | | |
157 | 196 | | |
| |||
181 | 220 | | |
182 | 221 | | |
183 | 222 | | |
| 223 | + | |
184 | 224 | | |
185 | 225 | | |
186 | 226 | | |
| |||
364 | 404 | | |
365 | 405 | | |
366 | 406 | | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
| 407 | + | |
| 408 | + | |
372 | 409 | | |
373 | 410 | | |
374 | 411 | | |
| |||
380 | 417 | | |
381 | 418 | | |
382 | 419 | | |
383 | | - | |
| 420 | + | |
384 | 421 | | |
385 | 422 | | |
386 | 423 | | |
| |||
426 | 463 | | |
427 | 464 | | |
428 | 465 | | |
| 466 | + | |
| 467 | + | |
429 | 468 | | |
430 | 469 | | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
| 470 | + | |
436 | 471 | | |
437 | 472 | | |
438 | 473 | | |
| |||
479 | 514 | | |
480 | 515 | | |
481 | 516 | | |
482 | | - | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
483 | 520 | | |
484 | 521 | | |
485 | 522 | | |
| |||
542 | 579 | | |
543 | 580 | | |
544 | 581 | | |
| 582 | + | |
| 583 | + | |
545 | 584 | | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | 585 | | |
552 | 586 | | |
553 | 587 | | |
| |||
614 | 648 | | |
615 | 649 | | |
616 | 650 | | |
617 | | - | |
618 | | - | |
619 | | - | |
620 | | - | |
621 | | - | |
| 651 | + | |
| 652 | + | |
622 | 653 | | |
623 | 654 | | |
624 | 655 | | |
| |||
706 | 737 | | |
707 | 738 | | |
708 | 739 | | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
709 | 743 | | |
710 | 744 | | |
711 | 745 | | |
| |||
723 | 757 | | |
724 | 758 | | |
725 | 759 | | |
726 | | - | |
727 | | - | |
728 | | - | |
729 | | - | |
730 | | - | |
| 760 | + | |
| 761 | + | |
731 | 762 | | |
732 | 763 | | |
733 | 764 | | |
| |||
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
0 commit comments