[STF] Extract standalone __places project from __stf/places#8189
Draft
caugonnet wants to merge 4 commits intoNVIDIA:mainfrom
Draft
[STF] Extract standalone __places project from __stf/places#8189caugonnet wants to merge 4 commits intoNVIDIA:mainfrom
caugonnet wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Contributor
Contributor
Author
|
/ok to test 21a427b |
andralex
reviewed
Mar 26, 2026
| target_link_libraries(${headertest_target} PUBLIC cudax.compiler_interface) | ||
| endif() | ||
|
|
||
| # FIXME: Enable MSVC |
Contributor
There was a problem hiding this comment.
What's the problem with msvc?
Contributor
Author
There was a problem hiding this comment.
CUDASTF is not supported / tested on Windows/MSVC
andralex
reviewed
Mar 26, 2026
andralex
reviewed
Mar 26, 2026
| #include <cuda/experimental/__places/data_place_interface.cuh> | ||
| #include <cuda/experimental/__places/exec/green_ctx_view.cuh> | ||
| #include <cuda/experimental/__places/places.cuh> | ||
| #include <cuda/experimental/__stf/utility/hash.cuh> |
Contributor
There was a problem hiding this comment.
I see code in __places still includes code in __stf. Is that an intermediary state of affairs and is the long-term plan to excise that dependency? Far as I can tell right now __places and __stf depend on each other.
Contributor
Author
There was a problem hiding this comment.
We need to decide where to move such utilities ...
This comment has been minimized.
This comment has been minimized.
andralex
reviewed
Mar 26, 2026
Comment on lines
+30
to
+31
| ../../cudax/include/cuda/experimental/__places \ | ||
| ../../cudax/include/cuda/experimental/__places/exec \ |
Contributor
There was a problem hiding this comment.
Would be nice to place these before the __stf files, not in between them.
Contributor
|
/ok to test 9560eaf |
Contributor
|
/ok to test 2570296 |
Move core place-concept headers (data_place, exec_place, stream_pool, green context, CUDA stream exec place, place_partition) from cudax/__stf/places/ into a new cudax/__places/ directory. Non-core files (tiled_partition, blocked_partition, cyclic_shape, callback_queues) remain in __stf/places/. All consumers are updated to include from the new __places/ paths directly (no forwarding headers). Add build/test infrastructure for __places: - cudax_ENABLE_PLACES CMake option - cudaxPlacesConfigureTarget.cmake for target configuration - Header compilation tests in cudaxHeaderTesting.cmake - UNITTESTED_FILE support via places_header_unittest.in.cu - Test directory with smoke test and header unit tests - CMakePresets.json updated to enable places Remove unused occupancy.cuh include from __places/places.cuh. Made-with: Cursor
…aces/places.cuh No types or functions from this header are used in places.cuh; the include was a leftover from before the deferred implementation was extracted to interpreted_execution_policy_impl.cuh. Made-with: Cursor
andralex
force-pushed
the
stf_standalone_places_v2
branch
from
4c45bcc to
a12219d
Compare
Contributor
|
/ok to test a12219d |
This comment has been minimized.
This comment has been minimized.
Use cuda::experimental::scope_exit instead of the STF-specific SCOPE(exit) macro. This removes __places' dependency on scope_guard.cuh (and transitively on unittest.cuh, traits.cuh, core.cuh), reducing the __stf -> __places coupling. Made-with: Cursor
Contributor
|
/ok to test 314272f |
The transitive include was broken when interpreted_execution_policy.cuh was removed from places.cuh. Made-with: Cursor
Contributor
|
/ok to test 5bbf017 |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 14m: Pass: 90%/445 | Total: 3d 05h | Max: 48m 37s | Hits: 99%/489910See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move core place-concept headers (data_place, exec_place, stream_pool, green context, CUDA stream exec place, place_partition) from cudax/__stf/places/ into a new cudax/__places/ directory. Non-core files (tiled_partition, blocked_partition, cyclic_shape, callback_queues) remain in __stf/places/.
All consumers are updated to include from the new __places/ paths directly (no forwarding headers).
Add build/test infrastructure for __places:
Remove unused occupancy.cuh include from __places/places.cuh.
Made-with: Cursor
Description
closes
Checklist