[STF] Rename getStream into get stream#7946
Draft
caugonnet wants to merge 15 commits intoNVIDIA:mainfrom
Draft
Conversation
place_partition.cuh does not use exec_affinity; the include was a leftover. Made-with: Cursor
This reverts commit 7fd0545.
Contributor
- Refactor data_place::to_string() to use cascaded ternary operators - Replace assert() calls with _CCCL_ASSERT for consistent diagnostics - Remove exec_place::impl::create_stream() and inline into stream_pool::next() - Simplify exec_place::operator->* to use exec_place_guard RAII pattern - Minor cleanup: remove redundant parentheses, reorder operator< logic
Contributor
|
/ok to test |
Contributor
@andralex, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
|
/ok to test 4e1b59b |
caugonnet
commented
Mar 10, 2026
|
|
||
| void* allocate(::std::ptrdiff_t, cudaStream_t) const override | ||
| { | ||
| throw ::std::logic_error("Cannot allocate from device_auto data_place directly"); |
Contributor
Author
There was a problem hiding this comment.
note: some methods throw, some other return NOT IMPLEMENTED
caugonnet
commented
Mar 10, 2026
| */ | ||
| virtual bool equals(const data_place_interface& other) const | ||
| { | ||
| return typeid(*this) == typeid(other) && get_device_ordinal() == other.get_device_ordinal(); |
Contributor
Author
There was a problem hiding this comment.
this looks like a remains of having the base data_place == data_place_device ? (this was in exec_place_device), maybe this should be a pure virtual = 0 ?
Contributor
😬 CI Workflow Results🟥 Finished in 36m 56s: Pass: 93%/48 | Total: 15h 01m | Max: 28m 28s | Hits: 59%/21875See results here. |
miscco
reviewed
Mar 10, 2026
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Can you rebase?
there are a lot of unrelated changes
Comment on lines
+113
to
+120
| bool allocation_is_stream_ordered() const override | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| // Provide affine exec place implementation for data_place::affine_exec_place() | ||
| ::std::shared_ptr<void> get_affine_exec_impl() const override; | ||
|
|
caugonnet
commented
Mar 10, 2026
| // under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. |
…VIDIA#7926) * prepare tests for var segments * adds tests for small variable-size segments * restores tests for types * reverts now-superfluous segment fixup test code * variable segment size tests * split up test tus, restore utils * adds tests for variable-size keys * fixes tu splitup * style fix
Contributor
I thought I'd make your life easier so I put the refactoring in #7976 for easy review. Will ping you when ready for review. Thanks! |
andralex
force-pushed
the
stf_rename_get_stream
branch
from
4e1b59b to
b30ffa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a consistent naming scheme
closes
Checklist