Address review comments

Author: amaslenn

src/cloudai/systems/slurm/slurm_command_gen_strategy.py

@@ -51,8 +51,11 @@ def __init__(self, system: System, test_run: TestRun) -> None:
         self.test_run = test_run
 
         self._node_spec_cache: dict[str, tuple[int, list[str]]] = {}
+
+    @property
+    def nodelist_in_use(self) -> bool:
         _, nodes = self.get_cached_nodes_spec()
-        self._nodelist_in_use: bool = len(nodes) > 0
+        return len(nodes) > 0
 
     @abstractmethod
     def _container_mounts(self) -> list[str]:
@@ -242,7 +245,7 @@ def image_path(self) -> Optional[str]:
     def gen_srun_prefix(self, use_pretest_extras: bool = False, with_num_nodes: bool = True) -> List[str]:
         num_nodes, _ = self.get_cached_nodes_spec()
         srun_command_parts = ["srun", "--export=ALL", f"--mpi={self.system.mpi}"]
-        if with_num_nodes and not self._nodelist_in_use:
+        if with_num_nodes and not self.nodelist_in_use:
             srun_command_parts.append(f"-N{num_nodes}")
         if use_pretest_extras and self.test_run.pre_test:
             for pre_tr in self.test_run.pre_test.test_runs:

tests/test_slurm_system.py

@@ -437,10 +437,10 @@ def test_per_test_isolation(self, mock_get_nodes: Mock, slurm_system: SlurmSyste
             ConcreteSlurmStrategy(slurm_system, test_run),
         )
 
-        assert mock_get_nodes.call_count == 2  # one call per strategy initialization
+        assert mock_get_nodes.call_count == 0
 
         res = strategy1.get_cached_nodes_spec()
-        assert mock_get_nodes.call_count == 2
+        assert mock_get_nodes.call_count == 1
         assert res == (2, ["node01", "node02"])
 
         res = strategy2.get_cached_nodes_spec()