Skip to content

Commit 1159eb7

Browse files
fix verify-configs
1 parent 507c141 commit 1159eb7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/cloudai/workloads/megatron_bridge/megatron_bridge.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ class MegatronBridgeCmdArgs(CmdArgs):
4040
detach: Optional[bool] = Field(default=None)
4141

4242
# Model/task
43-
model_name: str = Field(default="")
44-
model_size: str = Field(default="")
43+
model_name: str = Field(min_length=1)
44+
model_size: str = Field(min_length=1)
4545
domain: str = Field(default="llm")
4646
task: str = Field(default="pretrain")
4747
compute_dtype: str = Field(default="bf16")

tests/slurm_command_gen_strategy/test_megatron_bridge_slurm_command_gen_strategy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def cmd_gen(self, slurm_system: SlurmSystem, test_run: TestRun) -> MegatronBridg
8585

8686
def test_hf_token_empty_is_rejected_by_schema(self) -> None:
8787
with pytest.raises(Exception, match=r"hf_token"):
88-
MegatronBridgeCmdArgs.model_validate({"hf_token": ""})
88+
MegatronBridgeCmdArgs.model_validate({"hf_token": "", "model_name": "qwen3", "model_size": "30b_a3b"})
8989

9090
def test_git_repos_can_pin_megatron_bridge_commit(self) -> None:
9191
args = MegatronBridgeCmdArgs(hf_token="dummy_token", model_name="qwen3", model_size="30b_a3b")

0 commit comments

Comments
 (0)