Skip to content

Commit 120a3c5

Browse files
Incomplete test assertions
1 parent a054f4a commit 120a3c5

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/slurm_command_gen_strategy/test_megatron_bridge_slurm_command_gen_strategy.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,12 @@ def test_detach_flags(
175175
cmd_gen.gen_exec_command()
176176
wrapper = test_run.output_path / "megatron_bridge_submit_and_parse_jobid.sh"
177177
wrapper_content = wrapper.read_text()
178-
if expected:
179-
assert expected in wrapper_content
180178
if detach is None:
179+
assert "--detach" not in wrapper_content
180+
assert "--no-detach" not in wrapper_content
181+
else:
182+
assert expected is not None
183+
assert expected in wrapper_content
181184
assert not_expected not in wrapper_content
182185

183186
def test_generated_command_file_written(

0 commit comments

Comments
 (0)