Merge pull request #757 from NVIDIA/am/bug-4730612

Fix a crash during dry-run for Dynamo scenario

Author: amaslenn

src/cloudai/_core/base_installer.py

@@ -268,9 +268,12 @@ def mark_as_installed(self, items: Iterable[Installable]) -> InstallStatusResult
         Returns:
             InstallStatusResult: Result containing the status and error message if any.
         """
-        install_results = {}
+        install_results: dict[Installable, InstallStatusResult] = {}
         for item in self.all_items(items):
-            self.mark_as_installed_one(item)
+            result = self.mark_as_installed_one(item)
+            install_results[item] = result
+
+        self._populate_successful_install(items, install_results)
 
         return InstallStatusResult(True, "All items marked as installed successfully.", install_results)
 

src/cloudai/cli/handlers.py

@@ -289,6 +289,12 @@ def handle_dry_run_and_run(args: argparse.Namespace) -> int:
             logging.error("Failed to install workloads components.")
             logging.error(result.message)
             return 1
+    elif args.mode == "dry-run":
+        # simulate installation for dry-run
+        installables, installer = prepare_installation(system, tests, test_scenario)
+        result = installer.mark_as_installed(installables)
+        if not result.success:
+            logging.warning("Failed to mark workloads components as installed for dry-run.")
 
     logging.info(test_scenario.pretty_print())
 

tests/test_base_installer.py

@@ -293,6 +293,21 @@ def test_order_of_items_does_not_matter(self, installer: SlurmInstaller):
         )
         assert f2._installed_path is not None, "Second file was not marked as installed"
 
+    def test_both_mark_as_installed(self, installer: SlurmInstaller):
+        f1, f2 = File(src=Path(__file__)), File(src=Path(__file__))
+
+        assert f1 == f2, "Files should be equal"
+        assert f1 is not f2, "Files should be distinct objects"
+        assert f1._installed_path is None, "First file should not be installed before test"
+        assert f2._installed_path is None, "Second file should not be installed before test"
+
+        res = installer.mark_as_installed([f1, f2])
+
+        assert res.success, "mark_as_installed should succeed"
+        assert f1._installed_path is not None, "First file should have installed_path set"
+        assert f2._installed_path is not None, "Second file should have installed_path set"
+        assert f1._installed_path == f2._installed_path, "Files should have same installed_path"
+
 
 @pytest.fixture(params=["k8s", "slurm"])
 def installer(