Address review comments

Author: amaslenn

src/cloudai/_core/json_gen_strategy.py

@@ -56,7 +56,12 @@ def sanitize_k8s_job_name(self, job_name: str) -> str:
         sanitized_name = re.sub(r"[^a-z0-9-]", "-", sanitized_name)
         sanitized_name = re.sub(r"^[^a-z0-9]+", "", sanitized_name)
         sanitized_name = re.sub(r"[^a-z0-9]+$", "", sanitized_name)
-        return sanitized_name[:253]
+        final_name = sanitized_name[:253]
+
+        if not final_name:
+            raise ValueError(f"'{job_name}' cannot be sanitized to a valid Kubernetes job name.")
+
+        return final_name
 
     def store_test_run(self) -> None:
         from cloudai.models.scenario import TestRunDetails

src/cloudai/systems/kubernetes/kubernetes_system.py

@@ -449,7 +449,7 @@ def _delete_batch_job(self, job_name: str) -> None:
             )
             raise
 
-        api_response = cast("k8s.client.V1Job", api_response)
+        api_response = cast("k8s.client.V1Status", api_response)
         logging.debug(f"Batch job '{job_name}' deleted with status: {api_response.status}")
 
     def _delete_dynamo_graph_deployment(self, job_name: str) -> None:

tests/json_gen_strategy/test_common_kubernetes.py

@@ -41,3 +41,10 @@ def test_job_name_sanitization(k8s_system: KubernetesSystem, base_tr: TestRun, t
     base_tr.name = tname
     json_gen = MyJsonGenStrategy(k8s_system, base_tr)
     assert json_gen.sanitize_k8s_job_name(base_tr.name) == expected
+
+
+def test_job_name_sanitization_raises(k8s_system: KubernetesSystem, base_tr: TestRun) -> None:
+    base_tr.name = "!@#$%^&*()"
+    json_gen = MyJsonGenStrategy(k8s_system, base_tr)
+    with pytest.raises(ValueError):
+        json_gen.sanitize_k8s_job_name(base_tr.name)