Remove hardcoded value for data.index.mapping (#225)

srivatsankrishnan · web-flow · commit 228bb45b1493 · 2024-10-02T07:14:58.000-04:00
* Generate bash script for the command generation in Nemo launcher

* Fix linter issue

* Merge conflict fixes

* revert docker url back

* bug fix: remove hardcode data.index.mapping
diff --git a/src/cloudai/schema/test_template/nemo_launcher/slurm_command_gen_strategy.py b/src/cloudai/schema/test_template/nemo_launcher/slurm_command_gen_strategy.py
@@ -98,7 +98,6 @@ def _prepare_environment(self, cmd_args: Dict[str, str], extra_env_vars: Dict[st
         self.final_cmd_args.update(
             {
                 "base_results_dir": str(output_path_abs),
-                "training.model.data.index_mapping_dir": str(output_path_abs),
                 "launcher_scripts_path": str(launcher_path / "launcher_scripts"),
             }
         )

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,6 @@ def _prepare_environment(self, cmd_args: Dict[str, str], extra_env_vars: Dict[st`
`98`	`98`	`self.final_cmd_args.update(`
`99`	`99`	`{`
`100`	`100`	`"base_results_dir": str(output_path_abs),`
`101`		`- "training.model.data.index_mapping_dir": str(output_path_abs),`
`102`	`101`	`"launcher_scripts_path": str(launcher_path / "launcher_scripts"),`
`103`	`102`	`}`
`104`	`103`	`)`