Merge pull request #775 from NVIDIA/am/doc-urls

amaslenn · web-flow · commit 28c4246a6d0c · 2026-01-12T13:55:00.000+01:00
Do not use internal URLs in documentation
diff --git a/doc/workloads/ddlb.rst b/doc/workloads/ddlb.rst
@@ -15,7 +15,7 @@ Test TOML example:
    test_template_name = "DDLB"
 
    [cmd_args]
-   docker_image_url = "gitlab-master.nvidia.com/nsarkauskas/ddlb:latest"
+   docker_image_url = "<docker container url here>"
    primitive = "tp_columnwise"
    dtype = "float16"
 
@@ -48,7 +48,7 @@ Test-in-Scenario example:
    test_template_name = "DDLB"
 
      [Tests.cmd_args]
-     docker_image_url = "gitlab-master.nvidia.com/nsarkauskas/ddlb:latest"
+     docker_image_url = "<docker container url here>"
      primitive = "tp_columnwise"
      m = 1024
      n = 128
diff --git a/doc/workloads/deepep.rst b/doc/workloads/deepep.rst
@@ -26,7 +26,7 @@ Test TOML example (Standard Mode):
    test_template_name = "DeepEP"
 
    [cmd_args]
-   docker_image_url = "gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark"
+   docker_image_url = "<docker container url here>"
    mode = "standard"
    tokens = 1024
    num_experts = 256
@@ -45,7 +45,7 @@ Test TOML example (Low-Latency Mode):
    test_template_name = "DeepEP"
 
    [cmd_args]
-   docker_image_url = "gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark"
+   docker_image_url = "<docker container url here>"
    mode = "low_latency"
    tokens = 128
    num_experts = 256
@@ -83,7 +83,7 @@ Test-in-Scenario example:
    test_template_name = "DeepEP"
 
      [Tests.cmd_args]
-     docker_image_url = "gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark"
+     docker_image_url = "<docker container url here>"
      mode = "standard"
      tokens = 1024
      num_experts = 256
diff --git a/doc/workloads/nixl_bench.rst b/doc/workloads/nixl_bench.rst
@@ -15,7 +15,7 @@ Test TOML example:
    test_template_name = "NIXLBench"
 
    [cmd_args]
-   docker_image_url = "..."
+   docker_image_url = "<docker container url here>"
    path_to_benchmark = "/workspace/nixlbench/build/nixlbench"
    backend = "UCX"
    initiator_seg_type = "VRAM"
@@ -51,7 +51,7 @@ Test-in-Scenario example:
    test_template_name = "NIXLBench"
 
      [Tests.cmd_args]
-     docker_image_url = "..."
+     docker_image_url = "<docker container url here>"
      path_to_benchmark = "/workspace/nixlbench/build/nixlbench"
      backend = "UCX"
      initiator_seg_type = "DRAM"
diff --git a/doc/workloads/nixl_kvbench.rst b/doc/workloads/nixl_kvbench.rst
@@ -15,7 +15,7 @@ Test TOML example:
    test_template_name = "NIXLKVBench"
 
    [cmd_args]
-   docker_image_url = "..."
+   docker_image_url = "<docker container url here>"
    model = "./examples/model_deepseek_r1.yaml"
    model_config = "./examples/block-tp1-pp16.yaml"
    backend = "POSIX"
@@ -54,7 +54,7 @@ Test-in-Scenario example:
    test_template_name = "NIXLKVBench"
 
      [Tests.cmd_args]
-     docker_image_url = "..."
+     docker_image_url = "<docker container url here>"
      backend = "UCX"
      source = "memory"
      op_type = "READ"
diff --git a/doc/workloads/nixl_perftest.rst b/doc/workloads/nixl_perftest.rst
@@ -15,7 +15,7 @@ Test TOML example:
    test_template_name = "NixlPerftest"
 
    [cmd_args]
-   docker_image_url = "..."
+   docker_image_url = "<docker container url here>"
    subtest = "sequential-ct-perftest"
    num_user_requests = 1
    batch_size = 1
@@ -56,7 +56,7 @@ Test-in-Scenario example:
    test_template_name = "NixlPerftest"
 
      [Tests.cmd_args]
-     docker_image_url = "..."
+     docker_image_url = "<docker container url here>"
      subtest = "sequential-ct-perftest"
      num_user_requests = 100
      batch_size = 1
diff --git a/doc/workloads/osu.rst b/doc/workloads/osu.rst
@@ -16,7 +16,7 @@ Test example:
     description = "OSU Benchmark example"
 
     [cmd_args]
-    "docker_image_url" = "docker-image-with-osu-benchmark:latest"
+    "docker_image_url" = "<docker container url here>"
     "benchmarks_dir" = "/directory/with/osu/binaries/in/container"
     "benchmark" = ["osu_allreduce", "osu_allgather"]
     "iterations" = 10
@@ -50,7 +50,7 @@ Test-in-Scenario example:
     test_template_name = "OSUBench"
 
         [Tests.cmd_args]
-        docker_image_url = "docker-image-with-osu-benchmark:latest"
+        docker_image_url = "<docker container url here>"
         benchmarks_dir = "/directory/with/osu/binaries/in/container"
         benchmark = "osu_allreduce"
         iterations = 10
diff --git a/tests/ref_data/ddlb.sbatch b/tests/ref_data/ddlb.sbatch
@@ -10,8 +10,8 @@
 
 export SLURM_JOB_MASTER_NODE=$(scontrol show hostname $SLURM_JOB_NODELIST | head -n 1)
 
-srun --export=ALL --mpi=pmix -N1 --container-image=gitlab-master.nvidia.com/nsarkauskas/ddlb:latest --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --output=__OUTPUT_DIR__/output/mapping-stdout.txt --error=__OUTPUT_DIR__/output/mapping-stderr.txt bash -c "echo \$(date): \$(hostname):node \${SLURM_NODEID}:rank \${SLURM_PROCID}."
+srun --export=ALL --mpi=pmix -N1 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --output=__OUTPUT_DIR__/output/mapping-stdout.txt --error=__OUTPUT_DIR__/output/mapping-stderr.txt bash -c "echo \$(date): \$(hostname):node \${SLURM_NODEID}:rank \${SLURM_PROCID}."
 
-srun --export=ALL --mpi=pmix -N1 --container-image=gitlab-master.nvidia.com/nsarkauskas/ddlb:latest --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --ntasks=1 --ntasks-per-node=1 --output=__OUTPUT_DIR__/output/metadata/node-%N.toml --error=__OUTPUT_DIR__/output/metadata/nodes.err bash /cloudai_install/slurm-metadata.sh
+srun --export=ALL --mpi=pmix -N1 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output --ntasks=1 --ntasks-per-node=1 --output=__OUTPUT_DIR__/output/metadata/node-%N.toml --error=__OUTPUT_DIR__/output/metadata/nodes.err bash /cloudai_install/slurm-metadata.sh
 
-srun --export=ALL --mpi=pmix -N1 --container-image=gitlab-master.nvidia.com/nsarkauskas/ddlb:latest --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output bash -c "source __OUTPUT_DIR__/output/env_vars.sh; python ddlb/cli/benchmark.py --primitive tp_columnwise -m 1024 -n 128 -k 1024 --dtype float16 --num-iterations 50 --num-warmups 5 --impl pytorch;backend=nccl;order=AG_before"
+srun --export=ALL --mpi=pmix -N1 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output bash -c "source __OUTPUT_DIR__/output/env_vars.sh; python ddlb/cli/benchmark.py --primitive tp_columnwise -m 1024 -n 128 -k 1024 --dtype float16 --num-iterations 50 --num-warmups 5 --impl pytorch;backend=nccl;order=AG_before"
diff --git a/tests/ref_data/deepep-benchmark.sbatch b/tests/ref_data/deepep-benchmark.sbatch
@@ -20,8 +20,8 @@ echo Num Nodes: ${#nodes[@]}
 echo Head Node IP: $head_node_ip
 
 
-srun --export=ALL --mpi=pmix -N2 --container-image=gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results --output=__OUTPUT_DIR__/output/mapping-stdout.txt --error=__OUTPUT_DIR__/output/mapping-stderr.txt bash -c "echo \$(date): \$(hostname):node \${SLURM_NODEID}:rank \${SLURM_PROCID}."
+srun --export=ALL --mpi=pmix -N2 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results --output=__OUTPUT_DIR__/output/mapping-stdout.txt --error=__OUTPUT_DIR__/output/mapping-stderr.txt bash -c "echo \$(date): \$(hostname):node \${SLURM_NODEID}:rank \${SLURM_PROCID}."
 
-srun --export=ALL --mpi=pmix -N2 --container-image=gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results --ntasks=2 --ntasks-per-node=1 --output=__OUTPUT_DIR__/output/metadata/node-%N.toml --error=__OUTPUT_DIR__/output/metadata/nodes.err bash /cloudai_install/slurm-metadata.sh
+srun --export=ALL --mpi=pmix -N2 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results --ntasks=2 --ntasks-per-node=1 --output=__OUTPUT_DIR__/output/metadata/node-%N.toml --error=__OUTPUT_DIR__/output/metadata/nodes.err bash /cloudai_install/slurm-metadata.sh
 
-srun --export=ALL --mpi=pmix -N2 --container-image=gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results bash -c "source __OUTPUT_DIR__/output/env_vars.sh; torchrun --nnodes=2 --nproc_per_node=1 --rdzv_id=$RANDOM --rdzv_backend=c10d --rdzv_endpoint=$head_node_ip:29500 /workspace/dp-benchmark/benchmark/benchmark.py __OUTPUT_DIR__/output/config.yaml"
+srun --export=ALL --mpi=pmix -N2 --container-image=docker/image:url --container-mounts=__OUTPUT_DIR__/output:/cloudai_run_results,__OUTPUT_DIR__/install:/cloudai_install,__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:__OUTPUT_DIR__/output,__OUTPUT_DIR__/output:/workspace/dp-benchmark/results bash -c "source __OUTPUT_DIR__/output/env_vars.sh; torchrun --nnodes=2 --nproc_per_node=1 --rdzv_id=$RANDOM --rdzv_backend=c10d --rdzv_endpoint=$head_node_ip:29500 /workspace/dp-benchmark/benchmark/benchmark.py __OUTPUT_DIR__/output/config.yaml"
diff --git a/tests/test_acceptance.py b/tests/test_acceptance.py
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -294,7 +294,7 @@ def test_req(request, slurm_system: SlurmSystem, partial_tr: partial[TestRun]) -
                 description="ddlb",
                 test_template_name="ddlb",
                 cmd_args=DDLBCmdArgs(
-                    docker_image_url="gitlab-master.nvidia.com/nsarkauskas/ddlb:latest",
+                    docker_image_url="docker/image:url",
                     primitive="tp_columnwise",
                     m=1024,
                     n=128,
@@ -488,7 +488,7 @@ def test_req(request, slurm_system: SlurmSystem, partial_tr: partial[TestRun]) -
                 description="DeepEP MoE Benchmark",
                 test_template_name="deepep-benchmark",
                 cmd_args=DeepEPCmdArgs(
-                    docker_image_url="gitlab-master.nvidia.com/ybenabou/warehouse/deepep:dp-benchmark",
+                    docker_image_url="docker/image:url",
                 ),
             ),
         ),
