Skip to content

Commit 33eeff4

Browse files
fix pyright issue
1 parent 7593020 commit 33eeff4

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

tests/slurm_command_gen_strategy/test_megatron_bridge_slurm_command_gen_strategy.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def test_hf_token_empty_is_rejected_by_schema(self) -> None:
8888
MegatronBridgeCmdArgs.model_validate({"hf_token": ""})
8989

9090
def test_git_repos_can_pin_megatron_bridge_commit(self) -> None:
91-
args = MegatronBridgeCmdArgs(hf_token="dummy_token", model_name="qwen3", model_size="30b_a3b")
91+
args = MegatronBridgeCmdArgs(hf_token="dummy_token", model_family_name="qwen3", model_recipe_name="30b_a3b")
9292
tdef = MegatronBridgeTestDefinition(
9393
name="mb",
9494
description="desc",
@@ -223,20 +223,19 @@ def test_use_recipes_emitted_only_when_true(self, slurm_system: SlurmSystem, tmp
223223
sqsh = tmp_path / "img.sqsh"
224224
sqsh.write_text("x")
225225

226-
base = dict(
227-
container_image=str(sqsh),
228-
hf_token="dummy_token",
229-
model_family_name="qwen3",
230-
model_recipe_name="30b_a3b",
231-
num_gpus=8,
232-
gpus_per_node=4,
233-
)
234-
235226
tdef_true = MegatronBridgeTestDefinition(
236227
name="mb",
237228
description="desc",
238229
test_template_name="MegatronBridge",
239-
cmd_args=MegatronBridgeCmdArgs(**base, use_recipes=True),
230+
cmd_args=MegatronBridgeCmdArgs(
231+
container_image=str(sqsh),
232+
hf_token="dummy_token",
233+
model_family_name="qwen3",
234+
model_recipe_name="30b_a3b",
235+
num_gpus=8,
236+
gpus_per_node=4,
237+
use_recipes=True,
238+
),
240239
extra_container_mounts=[],
241240
git_repos=[
242241
{
@@ -267,7 +266,14 @@ def test_use_recipes_emitted_only_when_true(self, slurm_system: SlurmSystem, tmp
267266
name="mb",
268267
description="desc",
269268
test_template_name="MegatronBridge",
270-
cmd_args=MegatronBridgeCmdArgs(**base),
269+
cmd_args=MegatronBridgeCmdArgs(
270+
container_image=str(sqsh),
271+
hf_token="dummy_token",
272+
model_family_name="qwen3",
273+
model_recipe_name="30b_a3b",
274+
num_gpus=8,
275+
gpus_per_node=4,
276+
),
271277
extra_container_mounts=[],
272278
git_repos=[
273279
{

0 commit comments

Comments
 (0)