Skip to content

Commit 3f0d873

Browse files
Merge pull request #778 from srivatsankrishnan/m-bridge
Fix M-bridge report generation
2 parents 7663ca7 + 28435e5 commit 3f0d873

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/cloudai/workloads/megatron_bridge/report_generation_strategy.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
2-
# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
33
# SPDX-License-Identifier: Apache-2.0
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -31,12 +31,12 @@ class MegatronBridgeReportGenerationStrategy(ReportGenerationStrategy):
3131
metrics: ClassVar[list[str]] = ["default", "step-time", "tflops-per-gpu"]
3232

3333
def get_log_file(self) -> Path | None:
34-
log = self.test_run.output_path / "megatron_bridge_launcher.log"
34+
log = self.test_run.output_path / "cloudai_megatron_bridge_launcher.log"
3535
return log if log.is_file() else None
3636

3737
@property
3838
def results_file(self) -> Path:
39-
return self.get_log_file() or (self.test_run.output_path / "megatron_bridge_launcher.log")
39+
return self.get_log_file() or (self.test_run.output_path / "cloudai_megatron_bridge_launcher.log")
4040

4141
def can_handle_directory(self) -> bool:
4242
return self.get_log_file() is not None
@@ -75,8 +75,8 @@ def generate_report(self) -> None:
7575
log_file, step_times_s, gpu_tflops = self._get_extracted_data()
7676
if not log_file:
7777
logging.error(
78-
"No Megatron-Bridge launcher log file found: %s",
79-
self.test_run.output_path / "megatron_bridge_launcher.log",
78+
"No Megatron-Bridge launcher log file found in: %s",
79+
self.test_run.output_path,
8080
)
8181
return
8282

@@ -130,8 +130,8 @@ def get_metric(self, metric: str) -> float:
130130
log_file, step_times_s, gpu_tflops = self._get_extracted_data()
131131
if not log_file:
132132
logging.error(
133-
"No Megatron-Bridge launcher log file found: %s",
134-
self.test_run.output_path / "megatron_bridge_launcher.log",
133+
"No Megatron-Bridge launcher log file found in: %s",
134+
self.test_run.output_path,
135135
)
136136
return METRIC_ERROR
137137
if not step_times_s:

tests/report_generation_strategy/test_megatron_bridge_report_generation_strategy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
2-
# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
33
# SPDX-License-Identifier: Apache-2.0
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -38,7 +38,7 @@ def mb_tr(tmp_path: Path) -> TestRun:
3838
"",
3939
]
4040
)
41-
(tr.output_path / "megatron_bridge_launcher.log").write_text(log_content)
41+
(tr.output_path / "cloudai_megatron_bridge_launcher.log").write_text(log_content)
4242
return tr
4343

4444

0 commit comments

Comments
 (0)