Skip to content

Commit 452c179

Browse files
committed
Address review comments
1 parent 7298b60 commit 452c179

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/cloudai/systems/kubernetes/kubernetes_system.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -359,11 +359,14 @@ def _is_dynamo_graph_deployment_running(self, job: KubernetesJob) -> bool:
359359
self._genai_perf_completed = True
360360

361361
for pod_role in {"decode", "prefill", "frontend"}:
362-
pod_name = self._get_dynamo_pod_by_role(pod_role)
363-
logging.debug(f"Fetching logs for {pod_role=} {pod_name=}")
364-
logs = self.core_v1.read_namespaced_pod_log(name=pod_name, namespace=self.default_namespace)
365-
with (job.test_run.output_path / f"{pod_role}_pod.log").open("w") as f:
366-
f.write(logs)
362+
try:
363+
pod_name = self._get_dynamo_pod_by_role(pod_role)
364+
logging.debug(f"Fetching logs for {pod_role=} {pod_name=}")
365+
logs = self.core_v1.read_namespaced_pod_log(name=pod_name, namespace=self.default_namespace)
366+
with (job.test_run.output_path / f"{pod_role}_pod.log").open("w") as f:
367+
f.write(logs)
368+
except Exception as e:
369+
logging.debug(f"Error fetching logs for role '{pod_role}': {e}")
367370

368371
return False
369372

0 commit comments

Comments
 (0)