Use system install path instead of local member variables (#206)

Author: TaekyungHeo

src/cloudai/_core/test_template_strategy.py

@@ -28,7 +28,6 @@ class TestTemplateStrategy:
 
     Attributes
         system (System): The system schema object.
-        install_path (str): Path where the benchmarks are to be installed.
         env_vars (Dict[str, Any]): Default environment variables.
         cmd_args (Dict[str, Any]): Default command-line arguments.
         default_env_vars (Dict[str, str]): Constructed default environment variables.
@@ -47,7 +46,6 @@ def __init__(self, system: System, env_vars: Dict[str, Any], cmd_args: Dict[str,
             cmd_args (Dict[str, Any]): Default command-line arguments.
         """
         self.system = system
-        self.install_path = ""
         self.env_vars = env_vars
         self.cmd_args = cmd_args
         self.default_env_vars = self._construct_default_env_vars()

src/cloudai/schema/test_template/jax_toolbox/slurm_install_strategy.py

@@ -33,9 +33,7 @@ def is_installed(self) -> InstallStatusResult:
             return InstallStatusResult(success=True)
         else:
             if self.docker_image_cache_manager.cache_docker_images_locally:
-                expected_docker_image_path = (
-                    self.docker_image_cache_manager.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
-                )
+                expected_docker_image_path = self.system.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
                 return InstallStatusResult(
                     success=False,
                     message=(

src/cloudai/schema/test_template/nccl_test/slurm_install_strategy.py

@@ -39,9 +39,7 @@ def is_installed(self) -> InstallStatusResult:
             return InstallStatusResult(success=True)
         else:
             if self.docker_image_cache_manager.cache_docker_images_locally:
-                expected_docker_image_path = (
-                    self.docker_image_cache_manager.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
-                )
+                expected_docker_image_path = self.system.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
                 return InstallStatusResult(
                     success=False,
                     message=(

src/cloudai/schema/test_template/nemo_launcher/slurm_command_gen_strategy.py

@@ -23,12 +23,7 @@
 
 
 class NeMoLauncherSlurmCommandGenStrategy(SlurmCommandGenStrategy):
-    """
-    Command generation strategy for NeMo Megatron Launcher on Slurm systems.
-
-    Attributes
-        install_path (Path): The installation path of CloudAI.
-    """
+    """Command generation strategy for NeMo Megatron Launcher on Slurm systems."""
 
     def gen_exec_command(
         self,
@@ -44,7 +39,7 @@ def gen_exec_command(
         final_env_vars = self._override_env_vars(final_env_vars, extra_env_vars)
 
         launcher_path = (
-            self.install_path
+            self.system.install_path
             / NeMoLauncherSlurmInstallStrategy.SUBDIR_PATH
             / NeMoLauncherSlurmInstallStrategy.REPOSITORY_NAME
         )

src/cloudai/schema/test_template/nemo_launcher/slurm_install_strategy.py

@@ -65,7 +65,7 @@ def __init__(self, system: System, env_vars: Dict[str, Any], cmd_args: Dict[str,
         self.docker_image_url = cmd_args["docker_image_url"]
 
     def is_installed(self) -> InstallStatusResult:
-        subdir_path = self.install_path / self.SUBDIR_PATH
+        subdir_path = self.system.install_path / self.SUBDIR_PATH
         repo_path = subdir_path / self.REPOSITORY_NAME
         repo_installed = repo_path.is_dir()
 
@@ -117,7 +117,7 @@ def install(self) -> InstallStatusResult:
         except PermissionError as e:
             return InstallStatusResult(success=False, message=str(e))
 
-        subdir_path = self.install_path / self.SUBDIR_PATH
+        subdir_path = self.system.install_path / self.SUBDIR_PATH
         subdir_path.mkdir(parents=True, exist_ok=True)
 
         data_dir_path = Path(self.default_cmd_args["data_dir"])
@@ -171,10 +171,10 @@ def _check_install_path_access(self):
             PermissionError: If the install path does not exist or if there is no permission to create directories and
                 files.
         """
-        if not self.install_path.exists():
-            raise PermissionError(f"Install path {self.install_path} does not exist.")
-        if not self.install_path.is_dir() or not os.access(self.install_path, os.W_OK):
-            raise PermissionError(f"No permission to write in install path {self.install_path}.")
+        if not self.system.install_path.exists():
+            raise PermissionError(f"Install path {self.system.install_path} does not exist.")
+        if not self.system.install_path.is_dir() or not os.access(self.system.install_path, os.W_OK):
+            raise PermissionError(f"No permission to write in install path {self.system.install_path}.")
 
     def _check_datasets_on_nodes(self, data_dir_path: Path) -> DatasetCheckResult:
         """

src/cloudai/schema/test_template/ucc_test/slurm_install_strategy.py

@@ -39,9 +39,7 @@ def is_installed(self) -> InstallStatusResult:
             return InstallStatusResult(success=True)
         else:
             if self.docker_image_cache_manager.cache_docker_images_locally:
-                expected_docker_image_path = (
-                    self.docker_image_cache_manager.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
-                )
+                expected_docker_image_path = self.system.install_path / self.SUBDIR_PATH / self.DOCKER_IMAGE_FILENAME
                 return InstallStatusResult(
                     success=False,
                     message=(