Reflect Andrei's comments

Author: TaekyungHeo

src/cloudai/__main__.py

@@ -274,7 +274,7 @@ def main() -> None:
     system, tests, test_scenario = parser.parse(tests_dir, test_scenario_path)
 
     if output_dir:
-        system.output_path = Path(output_dir.absolute())
+        system.output_path = output_dir.absolute()
     system.update()
 
     if args.mode in ["install", "uninstall"]:

src/cloudai/parser/system_parser/slurm_system_parser.py

@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 from pathlib import Path
 from typing import Any, Dict, List
 
@@ -58,12 +57,12 @@ def str_to_bool(value: Any) -> bool:
         install_path = data.get("install_path")
         if not install_path:
             raise ValueError("Field 'install_path' is required.")
-        install_path = Path(os.path.abspath(install_path))
+        install_path = Path(install_path).absolute()
 
         output_path = data.get("output_path")
         if not output_path:
             raise ValueError("Field 'output_path' is required.")
-        output_path = Path(os.path.abspath(output_path))
+        output_path = Path(output_path).absolute()
 
         default_partition = data.get("default_partition")
         if not default_partition:

src/cloudai/parser/system_parser/standalone_system_parser.py

@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 from pathlib import Path
 from typing import Any, Dict
 
@@ -46,6 +45,6 @@ def parse(self, data: Dict[str, Any]) -> StandaloneSystem:
         output_path = data.get("output_path")
         if not output_path:
             raise ValueError("Field 'output_path' is required.")
-        output_path = Path(os.path.abspath(output_path))
+        output_path = Path(output_path).absolute()
 
         return StandaloneSystem(name=name, output_path=output_path)

src/cloudai/report_generator/tool/tensorboard_data_reader.py

@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 from pathlib import Path
 from typing import List, Tuple
 
@@ -43,15 +42,12 @@ def extract_data(self, tag: str) -> List[Tuple[int, float]]:
         from tbparse import SummaryReader  # lazy import to improve overall performance
 
         data = []
-        for root, _, files in os.walk(self.directory_path):
-            for file in files:
-                if file.startswith("events.out.tfevents"):
-                    path = Path(root) / file
-                    reader = SummaryReader(str(path))
-                    df = reader.scalars
-                    if tag in df["tag"].values:
-                        filtered_data = df[df["tag"] == tag]
-                        data.extend(filtered_data[["step", "value"]].values)
+        for path in self.directory_path.rglob("events.out.tfevents*"):
+            reader = SummaryReader(str(path))
+            df = reader.scalars
+            if tag in df["tag"].values:
+                filtered_data = df[df["tag"] == tag]
+                data.extend(filtered_data[["step", "value"]].values)
         return data
 
 

src/cloudai/schema/test_template/jax_toolbox/slurm_command_gen_strategy.py

@@ -216,7 +216,7 @@ def _create_run_script(
         env_vars: Dict[str, str],
         cmd_args: Dict[str, str],
         extra_cmd_args: str,
-    ) -> str:
+    ) -> None:
         """
         Generate and writes the run.sh script to the specified output directory.
 
@@ -230,9 +230,6 @@ def _create_run_script(
             cmd_args (Dict[str, str]): Command-line arguments.
             extra_cmd_args (str): Additional command-line arguments to be included
                                   in the srun command.
-
-        Returns:
-            str: The path to the run.sh script that was created.
         """
         test_name = self.test_name
 
@@ -267,7 +264,6 @@ def set_xla_flags(test_name: str, profile_enabled: bool):
         with open(run_script_path, "w") as run_file:
             run_file.write("\n".join(run_script_content))
         os.chmod(run_script_path, 0o755)
-        return str(run_script_path)
 
     def _script_content(
         self,

tests/test_slurm_report_generation_strategy.py

@@ -23,9 +23,10 @@
 
 
 @pytest.fixture
-def setup_test_environment(tmpdir):
+def setup_test_environment(tmp_path: Path):
     # Create a temporary directory for the test
-    test_dir = tmpdir.mkdir("test_env")
+    test_dir = tmp_path / "test_env"
+    test_dir.mkdir()
 
     # Create the mock stdout.txt file
     stdout_content = """