Merge branch 'main' into am/cmd-gen-use-tr-member

amaslenn · amaslenn · commit a99e0d908fa6 · 2025-07-02T15:25:22.000+02:00
diff --git a/conf/common/test/dse_nccl_all_gather.toml b/conf/common/test/dse_nccl_all_gather.toml
@@ -19,6 +19,7 @@ description = "all_gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_gather_perf_mpi"
 "ngpus" = "1"
 "minbytes" = "128"
diff --git a/conf/common/test/nccl_test.toml b/conf/common/test/nccl_test.toml
@@ -19,6 +19,7 @@ description = "NCCL base test configuration"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 ngpus = 1
 minbytes = "128"
 maxbytes = "4G"
diff --git a/conf/common/test/nccl_test_all_gather.toml b/conf/common/test/nccl_test_all_gather.toml
@@ -19,6 +19,7 @@ description = "all_gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_gather_perf_mpi"
 "ngpus" = "1"
 "minbytes" = "128"
diff --git a/conf/common/test_scenario/nccl_test.toml b/conf/common/test_scenario/nccl_test.toml
@@ -68,6 +68,7 @@ description = "scatter_perf"
 test_template_name = "NcclTest"
 
   [Tests.cmd_args]
+  docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
   subtest_name = "scatter_perf_mpi"
   ngpus = 1
   minbytes = "128"
diff --git a/conf/hook/test/nccl_test_all_gather.toml b/conf/hook/test/nccl_test_all_gather.toml
@@ -19,6 +19,7 @@ description = "all_gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_gather_perf_mpi"
 "ngpus" = "1"
 "minbytes" = "128"
diff --git a/conf/release/nemo_acceptance/test/nccl_test_all_reduce_loopback.toml b/conf/release/nemo_acceptance/test/nccl_test_all_reduce_loopback.toml
@@ -23,6 +23,7 @@ NCCL_P2P_DISABLE = "1"
 NCCL_SHM_DISABLE = "1"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_reduce_perf_mpi"
 "ngpus" = "1"
 "minbytes" = "8M"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_gather.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_gather.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "all_gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "all_gather_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_gather_worst.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_gather_worst.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "all_gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "all_gather_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_reduce.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_reduce.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "all_reduce"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_reduce_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_reduce_worst.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_all_reduce_worst.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "all_reduce_worst_alloc_test"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "all_reduce_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "alltoall"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "alltoall_perf_mpi"
 minbytes = "1k"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall_worst.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall_worst.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "alltoall_tested_job"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "alltoall_perf_mpi"
 minbytes = "1k"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall_worst_failover.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_alltoall_worst_failover.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "alltoall_tested_job"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "alltoall_perf_mpi"
 minbytes = "128M"
 maxbytes = "128M"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_bisection.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_bisection.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "nccl_test_bisection"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "bisection_perf_mpi"
 ngpus = "1"
 minbytes = "128"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_broadcast.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_broadcast.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,4 +19,5 @@ description = "broadcast"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "broadcast_perf_mpi"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_gather.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_gather.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,4 +19,5 @@ description = "gather"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "gather_perf_mpi"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_hypercube.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_hypercube.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,4 +19,5 @@ description = "hypercube"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "hypercube_perf_mpi"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,4 +19,5 @@ description = "reduce"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "reduce_perf_mpi"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce_scatter.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce_scatter.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "reduce_scatter"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "reduce_scatter_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce_scatter_worst.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_reduce_scatter_worst.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "reduce_scatter"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "reduce_scatter_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_scatter.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_scatter.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,4 +19,5 @@ description = "scatter"
 test_template_name = "NcclTest"
 
 [cmd_args]
+"docker_image_url" = "nvcr.io/nvidia/pytorch:24.02-py3"
 "subtest_name" = "scatter_perf_mpi"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_sendrecv.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_sendrecv.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "sendrecv"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "sendrecv_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/conf/release/spcx/l40s/test/l40s-bc-nccl_test_sendrecv_worst.toml b/conf/release/spcx/l40s/test/l40s-bc-nccl_test_sendrecv_worst.toml
@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 # SPDX-License-Identifier: Apache-2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,6 +19,7 @@ description = "sendrecv"
 test_template_name = "NcclTest"
 
 [cmd_args]
+docker_image_url = "nvcr.io/nvidia/pytorch:24.02-py3"
 subtest_name = "sendrecv_perf_mpi"
 minbytes = "1K"
 maxbytes = "16G"
diff --git a/src/cloudai/workloads/nccl_test/nccl.py b/src/cloudai/workloads/nccl_test/nccl.py
@@ -23,7 +23,7 @@
 class NCCLCmdArgs(CmdArgs):
     """NCCL test command arguments."""
 
-    docker_image_url: str = "nvcr.io/nvidia/pytorch:24.02-py3"
+    docker_image_url: str
     subtest_name: Union[
         Literal[
             "all_reduce_perf_mpi",
diff --git a/tests/report_generation_strategy/test_nccl_performance_report_generation_strategy.py b/tests/report_generation_strategy/test_nccl_performance_report_generation_strategy.py
@@ -32,7 +32,7 @@ def nccl_tr(tmp_path: Path) -> TestRun:
             name="nccl",
             description="desc",
             test_template_name="t",
-            cmd_args=NCCLCmdArgs(),
+            cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
         ),
         test_template=Mock(),
     )
diff --git a/tests/slurm_command_gen_strategy/test_common_slurm_command_gen_strategy.py b/tests/slurm_command_gen_strategy/test_common_slurm_command_gen_strategy.py
@@ -36,7 +36,7 @@ def testrun_fixture(tmp_path: Path, slurm_system: SlurmSystem) -> TestRun:
         name="test_job",
         description="Test description",
         test_template_name="d",
-        cmd_args=NCCLCmdArgs(),
+        cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
         extra_env_vars={"TEST_VAR": "VALUE"},
     )
 
@@ -125,7 +125,7 @@ def make_test_run(slurm_system: SlurmSystem, name: str, output_dir: Path) -> Tes
         name=name,
         description=name,
         test_template_name="nccl",
-        cmd_args=NCCLCmdArgs(),
+        cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
         extra_env_vars={"TEST_VAR": "VALUE"},
     )
     test_template = TestTemplate(slurm_system)
diff --git a/tests/slurm_command_gen_strategy/test_nccl_slurm_command_gen_strategy.py b/tests/slurm_command_gen_strategy/test_nccl_slurm_command_gen_strategy.py
@@ -55,7 +55,11 @@ def test_parse_slurm_args(
         expected_result: Dict[str, Any],
     ) -> None:
         nccl = NCCLTestDefinition(
-            name="name", description="desc", test_template_name="tt", cmd_args=NCCLCmdArgs(), extra_env_vars=env_vars
+            name="name",
+            description="desc",
+            test_template_name="NcclTest",
+            cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
+            extra_env_vars=env_vars,
         )
         t = Test(test_definition=nccl, test_template=Mock())
         tr = TestRun(name="t1", test=t, nodes=nodes, num_nodes=num_nodes)
@@ -72,7 +76,7 @@ def test_parse_slurm_args(
     )
     def test_generate_test_command(self, slurm_system: SlurmSystem, args: dict[str, Union[str, list[str]]]) -> None:
         cmd_args: NCCLCmdArgs = NCCLCmdArgs.model_validate({**{"docker_image_url": "fake_image_url"}, **args})
-        nccl = NCCLTestDefinition(name="name", description="desc", test_template_name="tt", cmd_args=cmd_args)
+        nccl = NCCLTestDefinition(name="name", description="desc", test_template_name="NcclTest", cmd_args=cmd_args)
         t = Test(test_definition=nccl, test_template=Mock())
         tr = TestRun(name="t1", test=t, nodes=[], num_nodes=1)
 
diff --git a/tests/test_acceptance.py b/tests/test_acceptance.py
@@ -282,7 +282,12 @@ def test_req(request, slurm_system: SlurmSystem, partial_tr: partial[TestRun]) -
             partial_tr,
             slurm_system,
             "nccl",
-            NCCLTestDefinition(name="nccl", description="nccl", test_template_name="nccl", cmd_args=NCCLCmdArgs()),
+            NCCLTestDefinition(
+                name="nccl",
+                description="nccl",
+                test_template_name="nccl",
+                cmd_args=NCCLCmdArgs(docker_image_url="nvcr.io/nvidia/pytorch:24.02-py3"),
+            ),
         ),
         "sleep": lambda: create_test_run(
             partial_tr,
diff --git a/tests/test_job_type_handler.py b/tests/test_job_type_handler.py
@@ -23,7 +23,12 @@
 
 @pytest.fixture
 def tr(slurm_system: SlurmSystem) -> TestRun:
-    tdef = NCCLTestDefinition(name="nccl", description="NCCL Test", test_template_name="nccl", cmd_args=NCCLCmdArgs())
+    tdef = NCCLTestDefinition(
+        name="nccl",
+        description="NCCL Test",
+        test_template_name="NcclTest",
+        cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
+    )
     return TestRun(
         name="test_run",
         test=Test(test_definition=tdef, test_template=TestTemplate(system=slurm_system)),
diff --git a/tests/test_reporter.py b/tests/test_reporter.py
@@ -57,7 +57,10 @@ def create_test_directories(slurm_system: SlurmSystem, test_run: TestRun) -> Non
 @pytest.fixture
 def benchmark_tr(slurm_system: SlurmSystem) -> TestRun:
     test_definition = NCCLTestDefinition(
-        name="nccl", description="NCCL test", test_template_name="NcclTest", cmd_args=NCCLCmdArgs()
+        name="nccl",
+        description="NCCL test",
+        test_template_name="NcclTest",
+        cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
     )
     test_template = TestTemplate(system=slurm_system)
     test = Test(test_definition=test_definition, test_template=test_template)
@@ -72,7 +75,7 @@ def dse_tr(slurm_system: SlurmSystem) -> TestRun:
         name="nccl",
         description="NCCL test",
         test_template_name="NcclTest",
-        cmd_args=NCCLCmdArgs(),
+        cmd_args=NCCLCmdArgs(docker_image_url="fake://url/nccl"),
         extra_env_vars={"VAR1": ["value1", "value2"]},
         agent_steps=12,
     )
diff --git a/tests/test_single_sbatch_runner.py b/tests/test_single_sbatch_runner.py
diff --git a/tests/test_slurm_system.py b/tests/test_slurm_system.py
diff --git a/tests/test_test_definitions.py b/tests/test_test_definitions.py
diff --git a/tests/test_test_scenario.py b/tests/test_test_scenario.py
